Add API commands to sign & verify arbitrary messages#1499
Merged
dariuskramer merged 19 commits intomasterfrom Aug 7, 2020
Merged
Add API commands to sign & verify arbitrary messages#1499dariuskramer merged 19 commits intomasterfrom
dariuskramer merged 19 commits intomasterfrom
Conversation
5c00653 to
defcc7d
Compare
added 8 commits
July 30, 2020 17:55
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
t-bast
requested changes
Jul 31, 2020
added 5 commits
August 4, 2020 17:20
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
t-bast
reviewed
Aug 6, 2020
eclair-core/src/main/scala/fr/acinq/eclair/crypto/KeyManager.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/EclairImplSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/crypto/LocalKeyManagerSpec.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/crypto/LocalKeyManagerSpec.scala
Show resolved
Hide resolved
eclair-node/src/main/scala/fr/acinq/eclair/api/ExtraDirectives.scala
Outdated
Show resolved
Hide resolved
eclair-node/src/main/scala/fr/acinq/eclair/api/FormParamExtractors.scala
Show resolved
Hide resolved
Signed-off-by: Donovan Jean <donovan@acinq.fr>
03a643d to
5f53fd9
Compare
added 3 commits
August 6, 2020 11:52
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
t-bast
reviewed
Aug 7, 2020
eclair-core/src/main/scala/fr/acinq/eclair/crypto/KeyManager.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Donovan Jean <donovan@acinq.fr>
Signed-off-by: Donovan Jean <donovan@acinq.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1496
End to End tests
Signby ->VerifiedbyHow to use the
signmessagecommandHow to use the
verifymessagecommandSignature format conversion
The signature we return are in hexadecimal format. Lnd & C-lightning use a zbase32 format. To convert from and to zbase32 you can use zbase32 and some basics Unix tools.
Hexadecimal to zbase32
zbase32 to Hexadecimal
Message format
We expect the
msgargument, for both commands, to be a valid base64 string, to avoid issues with charset and encoding: