Skip to content

Change MaximumProfitReceivingPeriodCount#3519

Merged
jason-aelf merged 11 commits into
release/1.7.0from
feature/change-max-profit-receiving-period-count
Jan 31, 2024
Merged

Change MaximumProfitReceivingPeriodCount#3519
jason-aelf merged 11 commits into
release/1.7.0from
feature/change-max-profit-receiving-period-count

Conversation

@louis4li
Copy link
Copy Markdown
Collaborator

Close #3518

@vizipi
Copy link
Copy Markdown

vizipi Bot commented Jan 25, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 200 8
100.00% jason-hoopox 25 8
75.00% 轩辕焮痕 1 6
62.50% gldeng 10 5
62.50% ZhangXin 10 5
50.00% kaiwenzhengaelf 4 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...contract/AElf.Contracts.Election/ElectionContract_Elector80.00%4 out of 5 times
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs80.00%4 out of 5 times
contract/AElf.Contracts.Treasury/TreasuryContract.cs80.00%4 out of 5 times
protobuf/token_contract.proto80.00%4 out of 5 times
test/AElf.Contracts.Election.Tests/BVT/ElectionTests.cs80.00%4 out of 5 times
protobuf/election_contract.proto80.00%4 out of 5 times
contract/AElf.Contracts.Consensus.AEDPoS/AEDPoSContract.cs80.00%4 out of 5 times
...contract/AElf.Contracts.Election/ElectionContract_Maintai80.00%4 out of 5 times
test/AElf.Contracts.Profit.Tests/ProfitContractTestBase.cs80.00%4 out of 5 times
test/AElf.Contracts.TestBase/ContractTester.cs80.00%4 out of 5 times

Committed file ranks

(click to expand)
  • 96.75%[contract/AElf.Contracts.Profit/ViewMethods.cs]
  • 98.74%[test/AElf.Contracts.Profit.Tests/ProfitTests.cs]
  • 82.35%[contract/AElf.Contracts.Profit/ProfitContractConstants.cs]
  • 99.76%[contract/AElf.Contracts.Profit/ProfitContract.cs]
  • 97.34%[...test/AElf.Contracts.Election.Tests/Full/ReleaseProfitsFro]
  • 98.55%[protobuf/profit_contract.proto]
  • 70.77%[...test/AElf.Contracts.Profit.Tests/ProfitContractTestConsta]
  • 94.03%[contract/AElf.Contracts.Profit/ProfitContractState.cs]
  • @codecov
    Copy link
    Copy Markdown

    codecov Bot commented Jan 25, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Comparison is base (7541806) 90.66% compared to head (ef9ae57) 90.69%.

    Additional details and impacted files

    Impacted file tree graph

    @@                Coverage Diff                @@
    ##           release/1.7.0    #3519      +/-   ##
    =================================================
    + Coverage          90.66%   90.69%   +0.03%     
    =================================================
      Files                663      663              
      Lines              25458    25500      +42     
      Branches            2285     2287       +2     
    =================================================
    + Hits               23082    23128      +46     
    + Misses              2260     2256       -4     
      Partials             116      116              
    Files Coverage Δ
    contract/AElf.Contracts.Profit/ProfitContract.cs 93.80% <100.00%> (+0.21%) ⬆️
    contract/AElf.Contracts.Profit/ViewMethods.cs 99.03% <100.00%> (+4.99%) ⬆️

    @jason-aelf jason-aelf merged commit 0c8e1dc into release/1.7.0 Jan 31, 2024
    @delete-merged-branch delete-merged-branch Bot deleted the feature/change-max-profit-receiving-period-count branch January 31, 2024 06:13
    @louis4li louis4li mentioned this pull request Feb 29, 2024
    1 task
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants