Skip to content

Enhance compatibility with historical NFT creation#3534

Merged
louis4li merged 3 commits into
release/1.8.0from
feature/create-token-on-specified-chain
Mar 7, 2024
Merged

Enhance compatibility with historical NFT creation#3534
louis4li merged 3 commits into
release/1.8.0from
feature/create-token-on-specified-chain

Conversation

@louis4li
Copy link
Copy Markdown
Collaborator

@louis4li louis4li commented Mar 7, 2024

No description provided.

@vizipi
Copy link
Copy Markdown

vizipi Bot commented Mar 7, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00% EanCuznaivy 38 3
100.00% Stephen01Zhang 18 3
100.00% kaiwenzhengaelf 6 3
100.00% zhifenglee-portkey 5 3
100.00% jason-hoopox 5 3
100.00% ZhangXin 2 3

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs89.47%17 out of 19 times
contract/AElf.Contracts.MultiToken/TokenContract_Helper.cs84.21%16 out of 19 times
...contract/AElf.Contracts.MultiToken/TokenContract_NFTHelpe78.95%15 out of 19 times
contract/AElf.Contracts.MultiToken/TokenContractState.cs57.89%11 out of 19 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenApplication57.89%11 out of 19 times
...test/AElf.Contracts.MultiToken.Tests/BVT/TokenManagementT57.89%11 out of 19 times
protobuf/token_contract_impl.proto52.63%10 out of 19 times
...contract/AElf.Contracts.MultiToken/AElf.Contracts.MultiTo52.63%10 out of 19 times
...contract/AElf.Contracts.MultiToken/TokenContract_ACS1_Met52.63%10 out of 19 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio52.63%10 out of 19 times

Committed file ranks

(click to expand)
  • 98.18%[...contract/AElf.Contracts.MultiToken/TokenContractConstants]
  • 96.74%[...contract/AElf.Contracts.MultiToken/TokenContract_NFT_Acti]
  • 94.01%[...test/AElf.Contracts.MultiToken.Tests/BVT/NftApplicationTe]
  • @codecov
    Copy link
    Copy Markdown

    codecov Bot commented Mar 7, 2024

    Codecov Report

    Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

    Project coverage is 90.70%. Comparing base (7dbd094) to head (821000d).

    Additional details and impacted files

    Impacted file tree graph

    @@              Coverage Diff               @@
    ##           release/1.8.0    #3534   +/-   ##
    ==============================================
      Coverage          90.70%   90.70%           
    ==============================================
      Files                663      663           
      Lines              25532    25543   +11     
      Branches            2293     2293           
    ==============================================
    + Hits               23158    23168   +10     
    - Misses              2258     2259    +1     
      Partials             116      116           
    Files Coverage Δ
    ....Contracts.MultiToken/TokenContract_NFT_Actions.cs 89.28% <92.30%> (+0.24%) ⬆️

    @louis4li louis4li merged commit 9133b3c into release/1.8.0 Mar 7, 2024
    @delete-merged-branch delete-merged-branch Bot deleted the feature/create-token-on-specified-chain branch March 7, 2024 07:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants