Fix provider setup composer refresh#30
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses stale chat composer model/provider state after AI provider configuration changes by broadcasting provider store mutations and reloading the composer when those notifications arrive.
Changes:
- Added an
aiProviderSettingsDidChangenotification name. - Posted that notification after provider settings or secrets are saved.
- Subscribed
ChatEditorViewModelto reload selected model state on provider changes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
macos/OpenBridge/Notifications/NotificationNames.swift |
Adds the AI provider settings change notification name. |
macos/OpenBridge/Interface/Chat/ChatEditorViewModel.swift |
Observes provider settings notifications and reloads composer model state. |
macos/OpenBridge/Agent/BridgeAIProviderSecretStore.swift |
Emits provider change notifications after settings/secret saves. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+138
to
+140
| .sink { [weak self] _ in | ||
| Task { [weak self] in | ||
| await self?.loadSelectedModel() |
Comment on lines
+134
to
+136
| private func setupAIProviderSettingsObservation() { | ||
| aiProviderSettingsCancellable = NotificationCenter.default | ||
| .publisher(for: .aiProviderSettingsDidChange) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29.
Notes
Draft PR #27 also touches this area as part of a broader runtime settings hot-reload change. This PR intentionally keeps the fix narrow and emits the notification at the provider store layer so any store mutation path can refresh the composer state.
Validation
BUILD_CONFIGURATION=UnsignedDebug bash DevKit/Scripts/workspace_build_debug.shswiftformat/swiftlinton modified Swift files