Skip to content

Fix float division by zero in benchmark #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FanhaiLu1 merged 2 commits into from
Apr 25, 2024
Merged

Fix float division by zero in benchmark #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6135248
Fix float division by zero in benchmark
FanhaiLu1 Apr 25, 2024
1e68c7d
Fix format
FanhaiLu1 Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions benchmarks/benchmark_serving.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,12 @@ def calculate_metrics(
)
total_output += output_len
total_input += input_requests[i].prompt_len
if output_len == 0:
print(
f"""-------- output_len is zero for {i}th request:,
output: {outputs[i]}"""
)
continue
per_token_latencies.append(outputs[i].latency / output_len)
ttfts.append(outputs[i].ttft)
completed += 1
Expand Down