refactor: update the adapted 7p and run lint for dsv4 example - #75
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
NinaCai
reviewed
Jul 30, 2026
|
|
||
| out = jnp.einsum("bmhk,bmkd->bmhd", attn_weights, kv_gathered) | ||
|
|
||
| return out |
Collaborator
There was a problem hiding this comment.
For future PRs, could you have separate PRs for different purposes?
Let's do lint before submitting PR.
NinaCai
reviewed
Jul 30, 2026
| ACTIVE_Q_LENS = (1,) * 48 + (512,) * 7 + (464,) | ||
| ACTIVE_KV_LENS = tuple( | ||
| 257 + ((i * 73) % 240) * 16 for i in range(48) | ||
| ) + (1023, 1535, 2047, 2559, 3071, 3583, 4095, 4095) |
Collaborator
There was a problem hiding this comment.
Out of curiosity, how do you pick these numbers?
Collaborator
Author
There was a problem hiding this comment.
This is a follow up from Charles'pr that changed tha JaxBench
NinaCai
approved these changes
Jul 31, 2026
NinaCai
left a comment
NinaCai
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Let's get the numbers for 7p after the code is merged. Would like to know the diff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.