Drop unneeded profiling events for timing accuracy#121
Merged
linamy85 merged 1 commit intoAI-Hypercomputer:mainfrom Apr 29, 2026
Merged
Drop unneeded profiling events for timing accuracy#121linamy85 merged 1 commit intoAI-Hypercomputer:mainfrom
linamy85 merged 1 commit intoAI-Hypercomputer:mainfrom
Conversation
Collaborator
|
Are you able to test if this will break other microbenchmarks (e.g. gemm, etc.)? |
Collaborator
Author
Yes, this was verified on Ironwood using other microbenchmarks. The numeric differences compared to the current main branch are considered within variance. |
chishuen
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have observed large data size and topology microbenchmark may yield large profiling trace exceeding the limit and hence lead to inaccurate timing.