cudnn flash attention GQA support#555
Closed
kocchop wants to merge 2 commits into
Closed
Conversation
kocchop
commented
Mar 26, 2024
kocchop
commented
Collaborator
- Used new stable API for cudnn flash attention
- It now has support for GQA
Collaborator
Author
|
@rwitten here is the PR for GQA support in Flash Attention. Please let me if you have any suggestions. |
rwitten
approved these changes
Apr 4, 2024
rwitten
left a comment
rwitten
left a comment
Collaborator
There was a problem hiding this comment.
Delegating to @yangyuwei for real approval
yangyuwei
approved these changes
Apr 4, 2024
yangyuwei
left a comment
yangyuwei
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for adding GQA support!
yangyuwei
approved these changes
Apr 8, 2024
yangyuwei
force-pushed
the
cudnn_flash_dpa
branch
from
9022b35 to
51f6d85
Compare
copybara-service Bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
-- 190a1a73753a665087be14f6f82823d24608cce6 by Md Fahim Faysal Khan <mdfahimfaysa@nvidia.com>: added support for GQA -- 9022b351c2d0e26fc1abbad228379b383cd3fa8a by Md Fahim Faysal Khan <mdfahimfaysa@nvidia.com>: added GQA support for cudnn flash attention COPYBARA_INTEGRATE_REVIEW=#555 from kocchop:cudnn_flash_dpa 9022b351c2d0e26fc1abbad228379b383cd3fa8a PiperOrigin-RevId: 622915708
Collaborator
|
The code changes have been pushed to Github via this commit (f04ba76) triggered by copybara. I'd close this PR. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.