Skip to content

Call max_utils.get_project() only when Vertex Tensorboard is enabled #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 11, 2024
+2 −4
Merged

Call max_utils.get_project() only when Vertex Tensorboard is enabled #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion MaxText/tests/train_gpu_smoke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class Train(unittest.TestCase):

def test_tiny_config(self):
test_tmpdir = os.environ.get("TEST_TMPDIR")
os.environ["TENSORBOARD_PROJECT"] = "test-project"
train_main([
None,
"third_party/py/maxtext/configs/gpu_smoke_test.yml",
Expand Down
1 change: 0 additions & 1 deletion MaxText/tests/train_int8_smoke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class Train(unittest.TestCase):

def test_tiny_config(self):
test_tmpdir = os.environ.get("TEST_TMPDIR")
os.environ["TENSORBOARD_PROJECT"] = "test-project"
train_main([None, "third_party/py/maxtext/configs/base.yml",
f"base_output_directory=gs://runner-maxtext-logs", "run_name=runner_test",
r"dataset_path=gs://maxtext-dataset",
Expand Down
1 change: 0 additions & 1 deletion MaxText/tests/train_smoke_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class Train(unittest.TestCase):

def test_tiny_config(self):
test_tmpdir = os.environ.get("TEST_TMPDIR")
os.environ["TENSORBOARD_PROJECT"] = "test-project"
train_main([None, "third_party/py/maxtext/configs/base.yml",
f"base_output_directory=gs://runner-maxtext-logs", "run_name=runner_test",
r"dataset_path=gs://maxtext-dataset",
Expand Down
3 changes: 2 additions & 1 deletion MaxText/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,8 @@ def main(argv: Sequence[str]) -> None:
validate_train_config(config)
os.environ["TFDS_DATA_DIR"] = config.dataset_path
vertex_tensorboard_manager = VertexTensorboardManager()
vertex_tensorboard_manager.configure_vertex_tensorboard(config)
if config.use_vertex_tensorboard or os.environ.get("UPLOAD_DATA_TO_TENSORBOARD"):
vertex_tensorboard_manager.configure_vertex_tensorboard(config)

debug_config = debug_configuration.DebugConfig(
stack_trace_config = stack_trace_configuration.StackTraceConfig(
Expand Down