Skip to content

Add convergence tests on A3 GPU#746

Merged
copybara-service[bot] merged 1 commit into
mainfrom
yooh/convergence-test
Jul 3, 2024
Merged

Add convergence tests on A3 GPU#746
copybara-service[bot] merged 1 commit into
mainfrom
yooh/convergence-test

Conversation

@michelle-yooh

Copy link
Copy Markdown
Collaborator

No description provided.

@michelle-yooh michelle-yooh requested a review from anfals July 2, 2024 22:07
@michelle-yooh michelle-yooh requested a review from gobbleturk as a code owner July 2, 2024 22:07

@anfals anfals left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, other than some minor comments about some print statements!

Comment thread end_to_end/gpu/a3/test_convergence_1b_params.sh Outdated
Comment thread end_to_end/gpu/a3/test_convergence_1b_params.sh Outdated
@michelle-yooh michelle-yooh force-pushed the yooh/convergence-test branch from eb19afc to 24a62b6 Compare July 3, 2024 00:55
@copybara-service copybara-service Bot merged commit 290dc66 into main Jul 3, 2024
@copybara-service copybara-service Bot deleted the yooh/convergence-test branch July 3, 2024 05:05
@michelle-yooh michelle-yooh restored the yooh/convergence-test branch September 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants