Fix validation error for other models#750
Merged
Merged
Conversation
RissyRan
force-pushed
the
fix_mega_validation
branch
from
3935619 to
491e466
Compare
RissyRan
force-pushed
the
fix_mega_validation
branch
from
491e466 to
eb5cf82
Compare
raymondzouu
approved these changes
Jul 3, 2024
raymondzouu
left a comment
raymondzouu
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the quick fix @RissyRan!
gobbleturk
approved these changes
Jul 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nightly gpt3 175b tests met megablox parallelism validatoin error
ValueError: Currently we only support Megablox with data parallelism(here). This is because we set megablox flag as True when cleaning up brute force implementation (here).The solution is to turn on this validation only for MoE model.
Test
Running train_compile.py script (non-MoE): link