Skip to content

Move num_experts pyconfig assertion to fix tests #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 10, 2024
+3 −3
Merged

Move num_experts pyconfig assertion to fix tests #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions MaxText/pyconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ def validate_keys(keys):
assert keys["local_checkpoint_period"] > 0, "A positive local checkpoint period must be specified when using emergency checkpoint"
else:
max_logging.log("Not using emergency checkpoint, ignoring local_checkpoint_directory and local_checkpoint_period")
if keys["num_experts"] > 1:
# Currently, Megablox only supports data parallelism
validate_megablox_parallelism(keys)


def validate_data_input(keys):
Expand Down Expand Up @@ -420,9 +423,6 @@ def validate_and_update_keys(raw_keys, model_keys, config_name: str):
"""Validate and update model specific config keys"""
max_logging.log("Updating following parameters in config\n")

if raw_keys["num_experts"] > 1:
# Currently, Megablox only supports data parallelism
validate_megablox_parallelism(raw_keys)

for k in model_keys:
max_logging.log(f"{k}: {model_keys[k]}")
Expand Down