【DO NOT MERGE!!!】init commit on deployment related configs(coding structure)#3
Open
hsballoon wants to merge 7 commits into
Open
【DO NOT MERGE!!!】init commit on deployment related configs(coding structure)#3hsballoon wants to merge 7 commits into
hsballoon wants to merge 7 commits into
Conversation
hsballoon
commented
May 19, 2026
| database: DatabaseConfig = field(default_factory=DatabaseConfig) | ||
| execution: ExecutionConfig = field(default_factory=ExecutionConfig) | ||
| runtime: RuntimeConfig = field(default_factory=RuntimeConfig) | ||
| deployment: DeploymentConfig = field(default_factory=DeploymentConfig) |
Collaborator
Author
There was a problem hiding this comment.
让全局config对象能带上新加的部署策略
hsballoon
commented
May 19, 2026
|
|
||
|
|
||
| VALID_NETWORK_MODES = {"online", "offline"} | ||
| VALID_RESOURCE_TIERS = {"light", "standard", "full"} |
Collaborator
Author
There was a problem hiding this comment.
定义合法值枚举类，校验的时候会用到。 如果资源配置需要改，这里也要改掉。
hsballoon
commented
May 19, 2026
| return self.network_mode == "offline" | ||
|
|
||
| @property | ||
| def light_resource_tier(self) -> bool: |
Collaborator
Author
There was a problem hiding this comment.
根据resource_tier自动判断资源档位。可以直接读这些 property，或者读policy.resource_tier。
如果后续资源配置改了，这里也跟着改一下。
hsballoon
commented
May 19, 2026
| level: str | ||
| code: str | ||
| message: str | ||
| checker_name: str | None = None |
Collaborator
Author
There was a problem hiding this comment.
用来统一表示preflight问题。 后面做network_mode / resource_tier相关的校验时安札个结构返回。
hsballoon
commented
May 19, 2026
|
|
||
|
|
||
| def handle_preflight_issues( | ||
| issues: list[PreflightIssue], |
hsballoon
commented
May 19, 2026
|
|
||
|
|
||
| def validate_selected_checkers( | ||
| *, |
Collaborator
Author
There was a problem hiding this comment.
第二层tool run preflight的检查总入口，会对每个最终选中的checker依次调用validate_checker_network_availability和validate_checker_resource_tier_availability。
各自实现具体逻辑。
hsballoon
commented
May 19, 2026
|
|
||
|
|
||
| def validate_checker_resource_tier_availability( | ||
| *, |
Collaborator
Author
There was a problem hiding this comment.
在这儿做checker min tier、显式的heavy checker报错、自动策略过滤等逻辑。自己决定
hsballoon
commented
May 19, 2026
| ), | ||
| strict=runtime_policy.strict_preflight, | ||
| logger=context.logger, | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
执行前加了个tool run preflight校验。
用户自然语言指定checker后，最终的checker集合会在这儿被检查。offline缺模型、缺LLM endpoint等问题会在run sample前失败。
hsballoon
commented
May 19, 2026
Collaborator
Author
hsballoon
left a comment
hsballoon
left a comment
There was a problem hiding this comment.
Comments added
…able this check before release)
Co-authored-by: chenbei <chenbei@pjlab.org.cn>
* add spacy model default config * add resource-tier checker preflight --------- Co-authored-by: chenbei <chenbei@pjlab.org.cn>
* enhance validation * fix agent pipeline postfix issue * refine security audit tool workflow --------- Co-authored-by: Shan He <t-shh@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.