Skip to content

chore(tools): clean up ConfigFilesGenerator inspection warnings #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
May 13, 2026
Merged

chore(tools): clean up ConfigFilesGenerator inspection warnings #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions tools/ConfigFilesGenerator/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ static ulong StableFnv1a(string value)
{
const ulong FnvOffsetBasis = 14695981039346656037UL;
const ulong FnvPrime = 1099511628211UL;
var bytes = System.Text.Encoding.UTF8.GetBytes(value.ToUpperInvariant());
var bytes = Encoding.UTF8.GetBytes(value.ToUpperInvariant());
var hash = FnvOffsetBasis;
foreach (var b in bytes)
{
Expand Down Expand Up @@ -565,11 +565,7 @@ static IReadOnlyDictionary<string, string> LoadMsBuildProperties(FullPath rootFo

var selfDefaultGuard = $"'$({name})' == ''";
if (string.Equals(NormalizeCondition(condition), selfDefaultGuard, StringComparison.Ordinal))
{
if (!properties.ContainsKey(name))
properties[name] = value;
continue;
}
properties.TryAdd(name, value);

// Unknown Condition shape: don't assume it's true.
}
Expand Down Expand Up @@ -750,10 +746,7 @@ static string ResolveMsBuildProperty(string value, IReadOnlyDictionary<string, s
return current;

var propertyName = match.Groups[1].Value;
if (!visited.Add(propertyName))
return current;

if (!properties.TryGetValue(propertyName, out var resolved))
if (!visited.Add(propertyName) || !properties.TryGetValue(propertyName, out var resolved))
return current;

current = resolved;
Expand All @@ -776,7 +769,7 @@ static FullPath GetRootFolderPath()
path = path.Parent;
}

return path.IsEmpty ? throw new InvalidOperationException("Cannot find the root folder") : path;
throw new InvalidOperationException("Cannot find the root folder");
}

static async Task<Assembly[]> GetAnalyzerReferences(string packageId, NuGetVersion version)
Expand Down
Loading