Skip to content

lossen up props.children#15

Closed
gorangajic wants to merge 1 commit intoAPSL:masterfrom
gorangajic:loosen-up-children-check
Closed

lossen up props.children#15
gorangajic wants to merge 1 commit intoAPSL:masterfrom
gorangajic:loosen-up-children-check

Conversation

@gorangajic
Copy link
Copy Markdown

fixes #14

@alvaromb
Copy link
Copy Markdown
Collaborator

Hi @gorangajic and sorry for the delay! 🍼 👶

I would prefer this instead of any prop type:

// Anything that can be rendered: numbers, strings, elements or an array
// (or fragment) containing these types.
optionalNode: React.PropTypes.node,

// A React element.
optionalElement: React.PropTypes.element,

Would that work for you?

@gorangajic gorangajic force-pushed the loosen-up-children-check branch from 53b73ef to 65bbe7b Compare January 11, 2016 08:54
@gorangajic
Copy link
Copy Markdown
Author

React.PropTypes.node works, updated commit

@charpeni
Copy link
Copy Markdown

Merge?

@aminroosta
Copy link
Copy Markdown

@alvaromb please merge this :-)

@gorangajic gorangajic force-pushed the loosen-up-children-check branch from 65bbe7b to a1a067d Compare April 14, 2016 17:03
@gorangajic
Copy link
Copy Markdown
Author

btw I have updated pull request again

@alvaromb
Copy link
Copy Markdown
Collaborator

Let's keep this feature on #29

@alvaromb alvaromb closed this Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can we lossen up props.children check?

4 participants