feat(mediator): name assembly-scanning APIs explicitly#794
Merged
AndreaCuneo merged 2 commits intoJul 26, 2026
Conversation
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndreaCuneo
July 26, 2026 06:06
View session
AndreaCuneo
marked this pull request as ready for review
July 26, 2026 06:06
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the mediator transport “assembly marker” APIs to make it explicit that the generic type parameter selects the assembly to scan, and updates generators + consumers accordingly to keep discovery behavior consistent across transports.
Changes:
- Renamed generated public APIs to
*FromAssembly<TAssemblyMarker>across Minimal API, gRPC, and Rebus, including updated generator call-site discovery. - Updated sample hosts and generator snapshot tests to use the new method names.
- Updated NuGet package descriptions and mediator docs/task tracking to reference the new names.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Ark.Tools.MediatorFramework.Tests/GeneratorSnapshotTests.cs | Updates snapshot assertions to the new generated method names. |
| src/mediator-framework/Ark.Tools.MediatorFramework.Rebus/Ark.Tools.MediatorFramework.Rebus.csproj | Updates package description to reference the new Rebus registration API name. |
| src/mediator-framework/Ark.Tools.MediatorFramework.Rebus.Generators/RebusEndpointGenerator.cs | Updates Rebus generator discovery and emitted API name + XML docs. |
| src/mediator-framework/Ark.Tools.MediatorFramework.MinimalApi/Ark.Tools.MediatorFramework.MinimalApi.csproj | Updates package description to reference the new Minimal API mapping method name. |
| src/mediator-framework/Ark.Tools.MediatorFramework.MinimalApi.Generators/MinimalApiEndpointGenerator.cs | Updates Minimal API generator discovery and emitted API name + XML docs. |
| src/mediator-framework/Ark.Tools.MediatorFramework.Grpc/Ark.Tools.MediatorFramework.Grpc.csproj | Updates package description to reference the new gRPC mapping method name. |
| src/mediator-framework/Ark.Tools.MediatorFramework.Grpc.Generators/GrpcEndpointGenerator.cs | Updates gRPC generator discovery and emitted API name + XML docs. |
| samples/Ark.MediatorFramework.Sample/src/Ark.MediatorFramework.Sample.WebInterface/SampleStartup.cs | Updates sample endpoint mapping calls to the new *FromAssembly methods. |
| samples/Ark.MediatorFramework.Sample/src/Ark.MediatorFramework.Sample.WebInterface/SampleComposition.cs | Updates sample Rebus handler registration call to the new *FromAssembly method. |
| docs/mediator-framework/tasks/security/SEC-03-messagepack-untrusted-data.md | Updates task references to the renamed Minimal API mapping method. |
| docs/mediator-framework/tasks/security/SEC-01-secure-by-default-endpoints.md | Updates task references to the renamed Minimal API mapping method. |
| docs/mediator-framework/tasks/README.md | Marks GEN-08 as completed. |
| docs/mediator-framework/tasks/generator-dx/GEN-08-from-assembly-api-names.md | Marks GEN-08 acceptance criteria as completed. |
| docs/mediator-framework/tasks/generator-dx/GEN-03-startup-handler-verification.md | Updates task references to the renamed APIs. |
| docs/mediator-framework/pre-release-review.md | Updates pre-release review notes to reference the renamed API. |
| docs/mediator-framework/migration-from-mvc.md | Updates migration guide references to the renamed Minimal API mapping method. |
| docs/mediator-framework/implementation-plan.md | Updates implementation plan references to the renamed Minimal API mapping method. |
| docs/mediator-framework/design.md | Updates design doc references to the renamed Minimal API mapping method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndreaCuneo
approved these changes
Jul 26, 2026
AndreaCuneo
deleted the
copilot/continue-next-task-docs-mediator-framework
branch
July 26, 2026 06:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic mediator registration APIs did not indicate that their type parameter selects the assembly to scan. This made call sites ambiguous and obscured cross-assembly discovery behavior.
MapArkEndpointsFromAssembly<TAssemblyMarker>MapArkGrpcServicesFromAssembly<TAssemblyMarker>RegisterArkRebusHandlersFromAssembly<TAssemblyMarker>