feat(mediator): advertise standard ProblemDetails responses - #799
Merged
Conversation
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndreaCuneo
July 26, 2026 18:11
View session
AndreaCuneo
marked this pull request as ready for review
July 26, 2026 18:12
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Mediator Minimal API generator to consistently advertise standard ProblemDetails error responses (400/403/500) in generated OpenAPI metadata, aligning endpoint documentation with runtime behavior and improving contract clarity for clients.
Changes:
- Emit
.Produces<ProblemDetails>(400/403/500, "application/problem+json")metadata for generated endpoints, skipping 403 forAllowAnonymous. - Return
ProblemDetailsresults for empty MessagePack request bodies and invalid multipart uploads. - Add/extend documentation and generator tests around the new standard error responses and collision handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Ark.Tools.MediatorFramework.Tests/GeneratorSnapshotTests.cs | Adds a generator test ensuring standard ProblemDetails responses are emitted without duplicate status declarations. |
| src/mediator-framework/Ark.Tools.MediatorFramework.MinimalApi.Generators/MinimalApiEndpointGenerator.cs | Adds ProblemMetadata(...) emission across endpoint shapes and switches some bad-request paths to Results.Problem(...). |
| docs/mediator-framework/design.md | Documents HTTP ProblemDetails ↔ gRPC canonical status code mappings (but currently breaks an existing markdown table). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndreaCuneo
requested changes
Jul 26, 2026
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
AndreaCuneo
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated mediator endpoints lacked OpenAPI declarations for standard 400/403/500 error responses.
Endpoint metadata
ProblemDetailswithapplication/problem+jsonon unary, command, upload, and download endpoints.Error responses
Documentation and coverage