Continuing the implementation of mediator framework tasks - #800
Merged
Conversation
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndreaCuneo
July 26, 2026 19:50
View session
AndreaCuneo
marked this pull request as ready for review
July 26, 2026 19:50
Contributor
There was a problem hiding this comment.
Pull request overview
Implements FW-08 (ETag preconditions) for the mediator framework Minimal API transport: introduces an [ETag] marker attribute, binds If-Match/If-None-Match: * into the request contract, and exposes OpenAPI documentation support for the optional header.
Changes:
- Add
[ETag]contract attribute in core and teach the Minimal API endpoint generator to bind ETag preconditions + emit OpenAPI metadata and diagnostics (ARKMF017/ARKMF018). - Add Minimal API runtime helper (
ArkETag) and OpenAPI extension (AddArkETagParameters) to documentIf-Matchwhen endpoints are ETag-enabled. - Extend mediator framework tests and docs to cover/describe ETag preconditions.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/Ark.Tools.MediatorFramework.Tests/MinimalApiHostingExtensionsTests.cs | Registers AddArkETagParameters() in OpenAPI options test chain. |
| tests/Ark.Tools.MediatorFramework.Tests/GeneratorSnapshotTests.cs | Adds/updates generator tests for ETag binding + diagnostics and adds runtime helper tests. |
| src/mediator-framework/Ark.Tools.MediatorFramework/ETagAttribute.cs | Introduces transport-agnostic [ETag] marker attribute for contracts. |
| src/mediator-framework/Ark.Tools.MediatorFramework.MinimalApi/ArkOpenApiEx.cs | Adds OpenAPI operation transformer to append optional If-Match header for ETag-enabled operations. |
| src/mediator-framework/Ark.Tools.MediatorFramework.MinimalApi/ArkETag.cs | Adds runtime helper for reading ETag preconditions and validating tokens; adds endpoint metadata marker. |
| src/mediator-framework/Ark.Tools.MediatorFramework.MinimalApi.Generators/MinimalApiEndpointGenerator.cs | Detects [ETag] property, emits header-binding assignment, emits metadata, and reports new diagnostics. |
| src/mediator-framework/Ark.Tools.MediatorFramework.MinimalApi.Generators/DiagnosticDescriptors.cs | Adds ARKMF017/ARKMF018 diagnostic descriptors for invalid/duplicate ETag declarations. |
| docs/mediator-framework/progress/tasks/README.md | Marks FW-08 as completed. |
| docs/mediator-framework/design.md | Documents optimistic concurrency via opaque ETag tokens and new diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AndreaCuneo
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request created by AI Agent