Skip to content

Prevent grpcurl port collision in CI - #863

Merged
AndreaCuneo merged 1 commit into
feature/mediator-framework-feedbacksfrom
copilot/fix-ci-build-failure-again
Aug 12, 2026
Merged

Prevent grpcurl port collision in CI#863
AndreaCuneo merged 1 commit into
feature/mediator-framework-feedbacksfrom
copilot/fix-ci-build-failure-again

Conversation

Copilot AI commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

The CI / Build check failed because the gRPC reflection test attempted to publish host port 50051 while Kestrel was already listening on it.

  • Test fix
    • Remove the redundant Docker -p 50051:50051 mapping.
    • Continue connecting through host.docker.internal:50051.
startInfo.ArgumentList.Add("--add-host=host.docker.internal:host-gateway");
startInfo.ArgumentList.Add("fullstorydev/grpcurl:latest");
startInfo.ArgumentList.Add($"host.docker.internal:{_grpcPort}");

Co-authored-by: AndreaCuneo <5227688+AndreaCuneo@users.noreply.github.com>
@AndreaCuneo
AndreaCuneo marked this pull request as ready for review August 12, 2026 16:48
@AndreaCuneo
AndreaCuneo requested a review from a team as a code owner August 12, 2026 16:48
Copilot AI lite review requested due to automatic review settings August 12, 2026 16:48
@AndreaCuneo
AndreaCuneo merged commit 2abdb35 into feature/mediator-framework-feedbacks Aug 12, 2026
5 of 7 checks passed
@AndreaCuneo
AndreaCuneo deleted the copilot/fix-ci-build-failure-again branch August 12, 2026 16:59
Copilot stopped reviewing on behalf of AndreaCuneo due to an error August 12, 2026 16:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Removes unnecessary Docker port publishing from the gRPC reflection integration test container invocation.

Changes:

  • Dropped -p / port mapping arguments from the docker run command used in the test.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants