Add eclipse illumination support to facetSRPDynamicEffector

[themouli]

• Tickets addressed: bsk-1335
• Review: By commit
• Merge strategy: Merge (no squash)

Description

Added an optional sunEclipseInMsg input to FacetSRPDynamicEffector so that eclipse shadow conditions are accounted for in the SRP force and torque calculation. When connected, the computed SRP force and torque are scaled by the shadow factor from the EclipseMsgPayload (0.0 = full shadow, 1.0 = full sunlight). When not connected, behavior is unchanged (defaults to full sunlight).

Verification

Updated the existing unit test with a new eclipseShadowFactor parametrization that creates and subscribes an EclipseMsg and scales the Python truth values accordingly.

Documentation

Updated facetSRPDynamicEffector.rst:

• Added sunEclipseInMsg to the Module I/O Messages table.
• Added a user guide step showing how to connect the eclipse message.

[schaubh]

@codex, do a fun review of this PR using AGENTS.md

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b4f91e446

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[schaubh]

Need to add info to release notes. We now do this by adding a small release notes RST snippet to docs/source/Support/bskReleaseNotesSnippets. For example, this file could contain

- added support for eclipse illumination factor to :ref:`facetSRPDynamicEffector`

[schaubh]

Also, please be sure to rebase, not merge, this branch on the latest code in develop.

[themouli]

Address all the comments.

• Updated to illuminationFactor instead of depreciated shadowFactor
• Added release notes
• Zero-initialized sunVisibilityFactor{} in the header
• Added default illumination factor before if statement

Ready for re-review. Thanks for thorough feedback @schaubh!

[themouli]

Cleaned the commit history

[schaubh]

Just minor renaming. I caught more instances of "shadow factor". Should be a quick fix. I can then close this after these changes.

[themouli]

I missed it. Updated them. Thank you!