fix(ci): stop the Dependency Graph check failing on every release#1334
Merged
Conversation
The repo home page showed a red ✗ on v0.7.0 (and v0.6.0/v0.6.1 before it). The failing check is GitHub's automatic dependency-graph job (`Dependency Graph` → `update-pip-graph`), not the release CI — every real gate (unit, container-security, CodeQL, schema-parity, image-smoke) passed. Root cause: `-e ./src/cli` in tests/requirements-test.txt. pip resolves that editable path against the working dir (repo root → src/cli ✓), but Dependabot's graph resolver resolves it against the manifest's own dir (tests/src/cli, which doesn't exist) → the updater errors → the check goes red on the release commit. Fix: drop the editable line from the scanned manifest and install the local CLI on demand from tests/setup-env.sh (sourced by every run-*.sh wrapper, so the local suite stays self-contained). CI only runs unit/, which never imports trinity_cli, so it is unaffected; the #660 one-liner contract is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dolho
approved these changes
Jun 24, 2026
vybe
added a commit
that referenced
this pull request
Jul 8, 2026
Release-prep: v0.8.0 (reconcile main + #1334 CI fix + version bump + notes)
Merged
pull Bot
pushed a commit
to bryanwills/trinity
that referenced
this pull request
Jul 9, 2026
…lease main diverged after v0.7.0 (Step-10 resync was skipped): the v0.7.0 squash plus 3 dependabot bumps (esbuild/form-data/vite — all superseded in dev) and the Abilityai#1334 CI fix. dev is authoritative; this -s ours merge records main as a parent so the dev->main release PR is clean. The Abilityai#1334 CI fix (missing from dev) is re-applied in the following commit.
pull Bot
pushed a commit
to bryanwills/trinity
that referenced
this pull request
Jul 9, 2026
…lease notes - VERSION 0.7.0 -> 0.8.0 (read by /api/version + baked into the backend image) - Re-apply Abilityai#1334: drop `-e ./src/cli` from tests/requirements-test.txt (it reds GitHub's Dependency-Graph check on every release) and install trinity_cli on demand from tests/setup-env.sh. The fix landed on main but was missing from dev. - Add docs/releases/0.8.0.md (110 issues across both trackers). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repo home page shows a red ✗ on the latest
maincommit (v0.7.0). It is not the release CI — every real gate passed (unit, container-security, CodeQL, schema-parity, image-smoke). The red comes from GitHub's automatic dependency-graph job (Dependency Graph→update-pip-graph), which has failed on every release since v0.6.0 (Jun 1 / Jun 12 / Jun 23).Root cause
-e ./src/cliintests/requirements-test.txt. pip resolves that editable path against the working dir (repo root →src/cli✓), but Dependabot's dependency-graph resolver resolves it against the manifest's own dir (tests/src/cli, which doesn't exist) → the updater errors → the check goes red on the release commit. On Jun 12 the/src/cligraph job passed while/testsfailed, isolating it to this line.Fix
tests/requirements-test.txt).tests/setup-env.sh, which everyrun-*.shwrapper sources — keeps the local suite self-contained (idempotent import-guarded install).tests/README.mdto match.CI only runs
unit/, which never importstrinity_cli, so CI is unaffected and the #660 one-liner contract is preserved.Durability note
This must also land on
dev(or be reconciled main→dev), otherwise the next release will re-introduce-e ./src/clifromdevand the red returns. Tracking that as a follow-up.🤖 Generated with Claude Code