docs(#945): correct actor-model postcard — result-reporting + taxonomy/citation accuracy#1358
Merged
Conversation
…uracy Audit-driven corrections to the actor-model postcard (the deliverable for #945, which originally landed via PR #1293/#946 with no #945 linkage): - Fix factual error: schedule_execution_completed IS emitted by the scheduler (src/scheduler/service.py) for schedule-triggered runs, but no agent-facing path consumes it and it's not emitted on the agent->agent MCP path the #946 pilot uses. Prior text wrongly said "never emitted"; the polling conclusion is unchanged. - Pin the shipped TaskExecutionErrorCode enum explicitly and note the contract adds OOM/MAX_TURNS on top, so the divergence is intentional. - Fix demotion-map citation: session_id unifies #8-#12 (not #8-#13); #13 inject_result is causation_id; drop the non-existent "continue_session". Closes #945 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The model has 14 fields today (src/backend/models.py:97-112), not 15 —
the demotion map's own code block already listed 14. Fix the prose counts
("13 of its 14 [optional]", "13 silent siblings"), the stale line-ref
(:84-99 -> :97-112), and the TARGET_ARCHITECTURE mirror of the claim.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
AndriiPasternak31
marked this pull request as ready for review
June 26, 2026 21:25
|
Resolve by running |
vybe
approved these changes
Jun 27, 2026
vybe
left a comment
Contributor
There was a problem hiding this comment.
✅ /validate-pr — APPROVE
Pure docs correction (3 files, docs/planning/*). Closes #945 (type-docs, same-repo → auto-promotes to status-in-dev on merge). No code, no security/packaging surface. Corrects postcard result-reporting + stale ParallelTaskRequest field count (15→14). All 4 required checks green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #945 — and finally links it to a PR.
The #945 deliverable (
docs/planning/ACTOR_MODEL_POSTCARD.md) already shipped todevin commitbc7e5fd2, but it rode in via PR #1293 (the #946 pull-pilot PR), which linkedCloses #946and never#945. So #945 stayed open. A line-by-line audit against the issue ACs + referenced design docs + the live codebase confirms the postcard satisfies every acceptance criterion (envelope fields, per-kindpayloads, typedreplyterminal-reason, result-reporting reframe, both-way cross-refs,BacklogServicebacklog_metadatacompatibility) — but surfaced one factual error and several citation/count nits, fixed here.Changes (docs-only, 3 files)
ACTOR_MODEL_POSTCARD.mdschedule_execution_completedwas described as "never emitted." It is emitted by the scheduler (src/scheduler/service.py, several_publish_eventsites) for schedule-triggered runs; it's simply not consumed by any agent-facing/MCP/frontend path and not emitted on the agent→agent MCP path the experiment: pull-coordination pilot — route MCP chat_with_agent through the agent queue #946 pilot uses. The polling conclusion is unchanged — only the supporting claim is corrected.TaskExecutionErrorCode({TIMEOUT, CAPACITY, AUTH, BILLING, AGENT_ERROR, NETWORK, CIRCUIT_OPEN, RECONCILED, LEASE_EXPIRED}) and make explicit that the contract addsOOM/MAX_TURNSon top, so the divergence is intentional rather than ambiguous.session_idunifies demotion-map security: implement safe tar extraction with symlink/hardlink validation #8–fix: Add ARM64 Alpine compatibility for frontend Docker build #12 (was security: implement safe tar extraction with symlink/hardlink validation #8–feat: SMARTS trading pipeline with Telegram notifications and Miro visualization #13); feat: SMARTS trading pipeline with Telegram notifications and Miro visualization #13inject_resultiscausation_id(already stated above); dropped the non-existent field namecontinue_session.ACTOR_MODEL_TASK_DEMOTION_MAP.md+TARGET_ARCHITECTURE.md4. Stale field count —
ParallelTaskRequesthas 14 fields today (src/backend/models.py:97-112), not 15. The demotion map's own code block already listed 14. Fixed the prose counts ("13 of its 14 optional", "13 silent siblings"), the stale line-ref (:84-99→:97-112), and theTARGET_ARCHITECTURE.mdmirror of the claim.Verification
git difftouches only the three planning docs.grep -rn schedule_execution_completed src/confirms the scheduler emitters;TaskExecutionErrorCodemembers match the added mapping line;ParallelTaskRequestfield count verified atsrc/backend/models.py:97-112(14).verify-localrun required.🤖 Generated with Claude Code