fix(ui): Tasks tab fills viewport height like the Chat tab (#1500)#1508
Merged
Conversation
…ecomes min-h-96 floor (#1500) The Tasks tab joins FULLSCREEN_TABS (the Chat tab's h-screen flex-fill layout): TasksPanel becomes a fill column whose root is also the short-viewport fallback scroller, and the task list absorbs remaining viewport height instead of scrolling inside a fixed max-h-96 box. The old cap is retained as the card's floor (min-h-96), so no viewport height ever shows fewer task rows than before. - AgentDetail.vue: FULLSCREEN_TABS = ['chat','tasks'] + panel contract comment; Tasks wrapper flex-fills (padding moved onto the panel's scroll root so content scrolls under it, scrollbar at the card edge) - TasksPanel.vue: root p-6 flex-1 flex-col gap-6 overflow-y-auto; history card flex-1 min-h-96 with the list as the flex-1 scroll region; loading/empty states center vertically; data-testid anchors - e2e: new agent-detail-tasks-fill-height.spec.js (floor >= old cap, growth-with-viewport, page-scroll containment, #954-class width parity, short-viewport composer reachability); repair the #954 spec's nav.-mb-px strict-mode breakage introduced by #1114's measuring mirror (.first()) - docs: tasks-tab.md layout section, session-tab.md stale fullscreen line, flow index row, learnings entry on ui-label-gated e2e rot Verified live: 5/5 e2e green; card grows 382->620px across a 1000->1400px viewport; no page scrollbar; composer reachable at 600px; dark+light modes; empty state centered. Fixes #1500 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Review: ✅ Approve on approach — The layout approach is sound: Blockers before merge:
|
|
Resolve by running |
…l-height # Conflicts: # docs/memory/feature-flows.md # docs/memory/learnings.md
…'t flake (#1500) The frontend-e2e run surfaced a second pre-existing infra flake (alongside the #954 spec repair): dashboard-grid-view timed out clicking the dashboard mode toggles because the first-run OnboardingWizard (trinity-enterprise#52) auto-opens on the CI stack's fresh, zero-user-agent Dashboard and its `fixed inset-0` backdrop intercepts pointer events. It's a race against fleet-load, so it was flaky, not deterministic, and local dev never reproduces it (a real stack has agents, so the wizard never auto-opens). Seed the product's own remembered-dismissal key (`trinity_onboarding_dismissed_v1`) in the shared auth.setup.js storageState — same origin as the JWT `token`, so it's captured by the snapshot every spec inherits. Fixes it fleet-wide with one line; specs that want the wizard opt back in via `?onboarding=1` (which bypasses the key by design). No app code changes. Adds a learnings entry for the fresh-install-only-modal class of e2e flake. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Review (direct). Tasks tab joins |
dolho
approved these changes
Jul 8, 2026
5 tasks
5 tasks
vybe
pushed a commit
that referenced
this pull request
Jul 9, 2026
…ui opt-in (#1526) (#1551) The frontend-e2e Playwright suite ran ONLY on `ui`-labeled PRs, so most PRs never triggered it and the suite rotted silently — specs broke against structural/UX changes and sat red on `dev` for weeks (four documented instances: #1134, #1508, #1378). The gate itself was the root cause. Add automatic triggers so a red suite is always visible: - Nightly `schedule` (07:00 UTC) on `dev` — the durable signal. A red nightly opens/updates a single tracking issue (new `report` job, label `frontend-e2e-nightly`), à la #1185; a green nightly closes it. - Auto-run on any PR that touches `src/frontend/**` (dependency-free `changes` job via `gh pr diff`), so frontend authors see their own breakage. - The `ui` label still works as a manual opt-in on non-frontend PRs and to force a run (preserved for the heavier @visual/@Interactive tiers, #596). - `workflow_dispatch` for on-demand runs. DECISION (AC): advisory, NOT a required merge gate. The recurring failure class is modal/overlay flake on a fresh zero-user-agent stack, so a hard gate like #715's unit gate needs a flake budget first (#596). Recorded in the workflow header. Per-job least-privilege permissions; concurrency keyed per-PR (cancel) vs per-ref (schedule, no cancel). Only @smoke runs in CI, unchanged. Related to #1526
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FULLSCREEN_TABS(the Chat tab'sh-screenflex-fill layout), so the task list absorbs the remaining viewport height instead of scrolling inside a fixedmax-h-96box on a mostly-empty page.max-h-96list cap is retained as the history card'smin-h-96floor — no viewport height ever shows fewer task rows than before. Live measurement drove this: fixed chrome (~780px on a populated agent) would otherwise leave a 222px list at a 1000px viewport, fewer rows than the old cap.TasksPanel's root is both the fill column and the short-viewport fallback scroller (load-bearing: the page cannot scroll in fullscreen mode, so without it short viewports would hard-clip the composer). Padding moved onto the scroll root so the scrollbar sits at the card edge.agent-detail-chat-width.spec.js): Agent Detail tabs: overflow into a "More" dropdown instead of horizontal scroll #1114's aria-hidden measuring mirror made the barenav.-mb-pxlocator a strict-mode violation; the suite only runs onui-labeled PRs, so the breakage was invisible until now (learnings entry added).Changes
src/frontend/src/views/AgentDetail.vue—FULLSCREEN_TABS = ['chat', 'tasks']+ panel contract comment; Tasks wrapper flex-fillssrc/frontend/src/components/TasksPanel.vue— fill-column restructure,min-h-96floor, uncappedflex-1list, vertically-centered loading/empty states,data-testidanchorssrc/frontend/e2e/agent-detail-tasks-fill-height.spec.js— new: floor ≥ old cap, growth-with-viewport (cap-removal signal robust to per-agent chrome height), page-scroll containment, Agent Detail: Chat tab content width jumps when switching to/from any other tab #954-class width parity, short-viewport composer reachabilitysrc/frontend/e2e/agent-detail-chat-width.spec.js—.first()repairdocs/memory/feature-flows/{tasks-tab,session-tab}.md,feature-flows.md,learnings.mdAccepted tradeoffs (from plan review)
Test Plan
npx playwright test e2e/agent-detail-tasks-fill-height.spec.js e2e/agent-detail-chat-width.spec.js— 5/5 passed against the live stack?execution=deep-link (scrollIntoView is container-agnostic), task expansion,?tab=tasksdeep-linkFixes #1500
🤖 Generated with Claude Code