Skip to content

refactor(frontend): sweep cross-cutting + chat + file-mgr + process + misc (#554) - #610

Closed
oleksandr-korin wants to merge 1 commit into
feature/554-sweep-auth-channels-viewsfrom
feature/554-sweep-misc-cross-cutting
Closed

refactor(frontend): sweep cross-cutting + chat + file-mgr + process + misc (#554)#610
oleksandr-korin wants to merge 1 commit into
feature/554-sweep-auth-channels-viewsfrom
feature/554-sweep-misc-cross-cutting

Conversation

@oleksandr-korin

Copy link
Copy Markdown
Contributor

Summary

Slice 7, stacked on #609. Migrates 24 files spanning the entire pool of small-and-medium domain files. Net diff: +106 / -106 — every change is a 1:1 palette alias, byte-identical CSS.

⚠️ Stacked on #609 (slices 4+5+6 + Vite proxy fix). GitHub will auto-rebase to `dev` once #609 merges.

Subdomains migrated

Chat (4 files)

  • `ChatBubble`, `ChatPanel`, `ChatInput`, `ChatHistoryDropdown` — error states, success indicators, self-task purple accent panel

File manager (4 files)

  • `FileManager` — toast notifications, delete confirmation modal, error states
  • `FileTreeNode` — search-matched highlight (file-type icons stay raw — need decorative accent palette later)
  • `FilePreview` — preview-error indicator
  • `FileSharingPanel` — Revoke button

Process domain (3 files)

  • `TrendChart` — full chart series (success/failure bars, cost bar, success-rate threshold ladder)
  • `RoleMatrix` — no-executor row + badge
  • `TemplateSelector` — category badges (business→info, devops→accent-purple, support→urgent)

Cross-cutting / modals (10 files)

  • `NavBar` — Ops critical-pulse indicator, WebSocket connected dot
  • `GitConflictModal` — warning header + all destructive (red) options
  • `ReplayTimeline` — system-agent purple panel + badge, schedule arrow, live-feed dot, success-rate ladder
  • `UnifiedActivityPanel` — running/success/fail indicators in both live row + detail modal
  • `OnboardingChecklist` — full completed-state styling (ring, bg, indicator, line-through text)
  • `CreateAgentModal` — templates-error and general error states
  • `ConfirmDialog` — danger/warning variants (icons, text, confirm buttons)
  • `AvatarGenerateModal` — error text, remove-avatar button
  • `HelpChatWidget` — error banner + retry button
  • `ResourceModal` — amber notice deferred (palette shift)

Misc (4 files)

  • `YamlEditor` — error/warning counts, banners, success checkmark
  • `EditorHelpPanel` — required-field indicator
  • `TerminalPanelContent` — restart-required notice, start-agent button
  • `TagsEditor` — error message

Deferred (consistent with prior slices)

Pattern Files affected Token gap
Primary action buttons (indigo / bg-blue-600 / hover:bg-blue-700) many `action-primary`
Selected-state styling (NavBar tabs, OperatingRoom tabs) NavBar `state-selected`
Amber notices (ResourceModal, FileSharingPanel notice, RoleMatrix amber missing-role marker) 3 accent palette expansion
File-type icon colors in `FileTreeNode` (folder yellow, video purple, audio green, image blue, pdf red) 1 decorative `accent-{color}` family
Slack / Telegram / WhatsApp brand logo colors 3 `brand-*` extensions for non-runtime brands

Verification

```
npm run check:tokens ✓ (10 tokens equivalent; all references resolve)
npm run build ✓
npm run test:e2e:smoke ✓ 7/7 passed (7.9s)
```

Test plan

  • CI `frontend-build` passes
  • CI `frontend-e2e` (`@smoke`) passes
  • Visual smoke: NavBar Ops counter, GitConflictModal (open conflict), confirmation dialogs, OnboardingChecklist completed items

Refs #554

🤖 Generated with Claude Code

… misc (#554)

Slice 7 stacked on #609. Migrates 24 files spanning the small-domain pool:

  CHAT (4 files)
    ChatBubble  — copy-success checkmark, self-task accent panel (purple)
    ChatPanel   — agent-not-running warning state, error banner
    ChatInput   — file-remove button, voice-active recording indicator
    ChatHistoryDropdown — error state

  FILE MANAGER (4 files)
    FileManager        — notification toast (success/error), no-agents warning,
                         loading error, delete button + modal + confirm action
    FileTreeNode       — search-matched row highlight (file-type icons stay raw
                         decorative; need their own accent palette later)
    FilePreview        — preview-error icon + text
    FileSharingPanel   — Revoke button

  PROCESS (3 files)
    TrendChart        — completed/failed/cost bars (chart series + legend),
                         success-rate threshold ladder
    RoleMatrix        — no-executor row + badge
    TemplateSelector  — category badges (business/devops/support → status-info /
                         accent-purple / status-urgent)

  CROSS-CUTTING / MODALS (10 files)
    NavBar               — Ops critical-pulse + high indicator, WS connected dot
    GitConflictModal     — yellow warning header (×2), all destructive (red) options
    ReplayTimeline       — system-agent purple panel + badge, schedule-marker arrow,
                            live-feed dot, activity-state success rate ladder
    UnifiedActivityPanel — running/success/fail indicators (live + modal)
    OnboardingChecklist  — completed-state styling (ring, bg, indicator, text)
    CreateAgentModal     — templates-error + general error
    ConfirmDialog        — danger/warning variant icons, text, confirm buttons
    ResourceModal        — (no migrations — amber notice, deferred)
    AvatarGenerateModal  — error text, remove-avatar button
    HelpChatWidget       — error banner + retry button

  MISC (3 files)
    YamlEditor          — error and warning banners + counts + success checkmark
    EditorHelpPanel     — required-field indicator
    TerminalPanelContent — restart-required notice, start-agent button
    TagsEditor          — error message

Net diff: 24 files, +106 / -106 (1:1 palette aliases, byte-identical CSS).

Deferred (existing pattern):
  - Indigo / blue primary action buttons (Login & elsewhere)
  - Blue selected-state (NavBar tabs, OperatingRoom tabs)
  - Amber notices (ResourceModal, RoleMatrix amber missing-role marker —
    these still use the amber palette which differs from yellow)
  - File-type icon colors in FileTreeNode (decorative, need accent-yellow /
    accent-purple-blue / etc. — folder ≠ warning, video ≠ accent, etc.)
  - Slack/Telegram/WhatsApp logo brand colors

These map to the pending `action-primary`, `state-selected`, and accent-color-
expansion tickets.

Verified locally:
  - npm run check:tokens                         passes (10 tokens valid)
  - npm run build                                passes
  - npm run test:e2e:smoke (7 tests, 7.9s)       all green

Refs #554

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@oleksandr-korin oleksandr-korin added the ui PR touches the frontend UI — triggers Playwright e2e tests label Apr 30, 2026
@oleksandr-korin
oleksandr-korin deleted the branch feature/554-sweep-auth-channels-views May 1, 2026 10:32
@oleksandr-korin
oleksandr-korin deleted the feature/554-sweep-misc-cross-cutting branch May 1, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui PR touches the frontend UI — triggers Playwright e2e tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant