Adsk contrib - Add support for minimum and recommended versions for dependencies by cedrik-fuoco-adsk · Pull Request #1772 · AcademySoftwareFoundation/OpenColorIO

cedrik-fuoco-adsk · 2023-02-23T18:15:19Z

Adding support for minimum, maximum and recommended versions for OCIO dependencies.

Added two new macros to handle the logic: ocio_handle_dependency and ocio_install_dependency.
The download and install part of each OCIO dependency are now split into two files.
- Under share/cmake/modules/FindXYZ.cmake and share/cmake/modules/install/InstallXYZ.cmake
Added an option OCIO_VERBOSE to print more information when CMake is calling the Find modules.
Refactored what gets printed when we build as well as some colours when modules are found.
FindOpenImageIO.cmake was removed in favour of their CMake configuration file (as recommended by OIIO). The FindOpenImageIO.cmake that we had was coming from OIIO originally, but it is not supported anymore.
FindOpenEXR.cmake was removed in favour of their CMake configuration files. Our FindOpenEXR.cmake was basically just doing a search for their CMake's configuration files, but we don't need a whole Find module to do that.

Here's a snippet of a build log:

Implemention of minimum, maximum and recommended version. Refactor the FindOpenImageIO to be inline with the rest of the custom find module (OCIO_USE_OIIO_CMAKE_CONFIG is no longer needed). Added a new option called OCIO_VERBOSE. It allow the user to tell OCIO to display more information when searching and building the dependencies. Splitted the find and install part into two files - Find<pkg>.cmake and Install<pkg>.cmake. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Setting policy CMP0042 when building ZLIB since that project is using an old CMake version as the cmake_minimum_required and that version has no knowledge of the policy. Fixing a potential issue in Installopenfx. Changing back the version to 1.4 as before. Ignoring warning from OpenImageIO for imageioapphelpers. The same warning are ignored for ociodisplay, ocioconvert and ociolutimage. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…acOS. Renamed FindOpenShadingLanguage to FindOSL to match the project name used the OSL's CMakefile. Cleanup the code for FindOSL and removed duplicate warning about needed C++14. Updated the header comments for all Find and Install modules. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Renamed ocio_install_package to ocio_install_dependency The "Installing [...]" message from Install module is now under OCIO_VERBOSE variable. Added a message in ocio_install_dependency instead Improve the colors usage in the logging Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ith the prefix of ocio_handle_dependency since they were the same. Removed FindOpenEXR.cmake and FindOpenImageIO.cmake since they are not needed anymore (for differente reason). Added PROMOTE_TARGET option for ocio_handle_dependency which promote the target to GLOBAL. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Re-worded some of the comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ting OCIO_INSTALL_EXT_PACKAGES option correctly. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ib since the user can update their cmake in order to do that. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

cedrik-fuoco-adsk · 2023-03-08T14:19:06Z

I am working on the failure in the Linux CI. The issue comes up when OpenImageIO is found via OpenImageIOConfig.cmake.
I've identified the issue and I'm working on a solution. The issue is present in the main branch as well.

remia

Amazing work @cedrik-fuoco-adsk!

Would be great to finally get rid of OIIO custom Find module, I think this was already tried a couple of times in the past. I would think it may be ok to bump the minimum version required if that helps in the process (for OCIO 2.3 obviously).

Thinking in terms of different compilation path now that we support more flexibility in version dependencies (tagging @Shootfast), is there something we could add to check what were the different dependencies versions from the compiled library? Not sure it's needed here for this PR but might be useful for debugging down the line. (Don't have a strong opinion about this, just raising the point. We already allowed flexible versions for Imath and OpenEXR before.)

* Update CI workflows Signed-off-by: Rémi Achard <remiachard@gmail.com> * Test building OpenEXR single threaded Signed-off-by: Rémi Achard <remiachard@gmail.com> * Add comment on disabling parallel build Signed-off-by: Rémi Achard <remiachard@gmail.com> * Update python_requires Signed-off-by: Rémi Achard <remiachard@gmail.com> * Remove comments around CI jobs Signed-off-by: Rémi Achard <remiachard@gmail.com> --------- Signed-off-by: Rémi Achard <remiachard@gmail.com>

…ATH environment variable (AcademySoftwareFoundation#1759) * Allow PyOpenColorIO module to load DLLs from Windows PATH environment variable with an opt-out option in case the user want the default behavior of Python 3.8+. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Fixing typos in comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com>

…Foundation#1765) Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com>

…here ocio_install_dependency would be used without ocio_handle_dependency. Added a new function named ocio_check_dependency_version to check the version of a package without propagating any variables set by find_package. Fix for Linux CI. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Implemention of minimum, maximum and recommended version. Refactor the FindOpenImageIO to be inline with the rest of the custom find module (OCIO_USE_OIIO_CMAKE_CONFIG is no longer needed). Added a new option called OCIO_VERBOSE. It allow the user to tell OCIO to display more information when searching and building the dependencies. Splitted the find and install part into two files - Find<pkg>.cmake and Install<pkg>.cmake. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Setting policy CMP0042 when building ZLIB since that project is using an old CMake version as the cmake_minimum_required and that version has no knowledge of the policy. Fixing a potential issue in Installopenfx. Changing back the version to 1.4 as before. Ignoring warning from OpenImageIO for imageioapphelpers. The same warning are ignored for ociodisplay, ocioconvert and ociolutimage. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…acOS. Renamed FindOpenShadingLanguage to FindOSL to match the project name used the OSL's CMakefile. Cleanup the code for FindOSL and removed duplicate warning about needed C++14. Updated the header comments for all Find and Install modules. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Renamed ocio_install_package to ocio_install_dependency The "Installing [...]" message from Install module is now under OCIO_VERBOSE variable. Added a message in ocio_install_dependency instead Improve the colors usage in the logging Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ith the prefix of ocio_handle_dependency since they were the same. Removed FindOpenEXR.cmake and FindOpenImageIO.cmake since they are not needed anymore (for differente reason). Added PROMOTE_TARGET option for ocio_handle_dependency which promote the target to GLOBAL. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Re-worded some of the comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ting OCIO_INSTALL_EXT_PACKAGES option correctly. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ib since the user can update their cmake in order to do that. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…here ocio_install_dependency would be used without ocio_handle_dependency. Added a new function named ocio_check_dependency_version to check the version of a package without propagating any variables set by find_package. Fix for Linux CI. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…rsions-for-dependencies' of https://github.com/autodesk-forks/OpenColorIO into adsk_contrib/add-support-for-minimum-and-recommended-versions-for-dependencies

Implemention of minimum, maximum and recommended version. Refactor the FindOpenImageIO to be inline with the rest of the custom find module (OCIO_USE_OIIO_CMAKE_CONFIG is no longer needed). Added a new option called OCIO_VERBOSE. It allow the user to tell OCIO to display more information when searching and building the dependencies. Splitted the find and install part into two files - Find<pkg>.cmake and Install<pkg>.cmake. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Setting policy CMP0042 when building ZLIB since that project is using an old CMake version as the cmake_minimum_required and that version has no knowledge of the policy. Fixing a potential issue in Installopenfx. Changing back the version to 1.4 as before. Ignoring warning from OpenImageIO for imageioapphelpers. The same warning are ignored for ociodisplay, ocioconvert and ociolutimage. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…acOS. Renamed FindOpenShadingLanguage to FindOSL to match the project name used the OSL's CMakefile. Cleanup the code for FindOSL and removed duplicate warning about needed C++14. Updated the header comments for all Find and Install modules. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Renamed ocio_install_package to ocio_install_dependency The "Installing [...]" message from Install module is now under OCIO_VERBOSE variable. Added a message in ocio_install_dependency instead Improve the colors usage in the logging Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ith the prefix of ocio_handle_dependency since they were the same. Removed FindOpenEXR.cmake and FindOpenImageIO.cmake since they are not needed anymore (for differente reason). Added PROMOTE_TARGET option for ocio_handle_dependency which promote the target to GLOBAL. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Re-worded some of the comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ting OCIO_INSTALL_EXT_PACKAGES option correctly. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…ib since the user can update their cmake in order to do that. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…here ocio_install_dependency would be used without ocio_handle_dependency. Added a new function named ocio_check_dependency_version to check the version of a package without propagating any variables set by find_package. Fix for Linux CI. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

…rsions-for-dependencies' of https://github.com/autodesk-forks/OpenColorIO into adsk_contrib/add-support-for-minimum-and-recommended-versions-for-dependencies Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

cedrik-fuoco-adsk · 2023-03-09T18:19:53Z

Sorry, I messed up my branch while trying to rebase. I might have to do a redo.

cedrik-fuoco-adsk · 2023-03-09T18:46:58Z

Closing in favour of #1777 (redo)

cedrik-fuoco-adsk added 14 commits January 24, 2023 15:57

Fixing typo

cd47a1b

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Mostly comments and documentations

be2dabe

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Small update of the Existing Install Hints section

f45ac54

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Changed RECOMMENDED_MIN_VERSION to RECOMMENDED_VERSION

fb30c9d

Re-worded some of the comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Fixing issue with ocio_handle_dependency macro where it wasn't respec…

669b2a6

…ting OCIO_INSTALL_EXT_PACKAGES option correctly. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Adding more documentations and dropping support to look for static zl…

76157e3

…ib since the user can update their cmake in order to do that. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Documentations

8f2f41a

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Documentations

a4f78c5

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

fixing typo

2019486

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

lgritz reviewed Feb 23, 2023

View reviewed changes

Comment thread share/cmake/modules/FindExtPackages.cmake Outdated

Fix typoe and fix issue when OCIO is installing ZLIB

39e1c67

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

cedrik-fuoco-adsk mentioned this pull request Mar 7, 2023

Adsk Contrib - Add support for ARM Neon intrinsics and Universal builds #1775

Closed

remia reviewed Mar 8, 2023

View reviewed changes

Comment thread share/cmake/modules/FindExtPackages.cmake Outdated

Comment thread src/libutils/imageioapphelpers/CMakeLists.txt

Comment thread share/cmake/modules/FindExtPackages.cmake

Comment thread CMakeLists.txt

remia and others added 11 commits March 8, 2023 22:07

Changing the build type check to be case-insensitive (AcademySoftware…

9d572cf

…Foundation#1765) Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Co-authored-by: Doug Walker <doug.walker@autodesk.com>

Fixing typo

4dec235

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Mostly comments and documentations

0a0d33a

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

cedrik-fuoco-adsk added 26 commits March 9, 2023 12:10

Changed RECOMMENDED_MIN_VERSION to RECOMMENDED_VERSION

7f22813

Re-worded some of the comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Fixing issue with ocio_handle_dependency macro where it wasn't respec…

53d89a4

…ting OCIO_INSTALL_EXT_PACKAGES option correctly. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Adding more documentations and dropping support to look for static zl…

af595f2

…ib since the user can update their cmake in order to do that. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Documentations

9ff994e

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Documentations

cc5aa65

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

fixing typo

22b12cf

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Fix typoe and fix issue when OCIO is installing ZLIB

e7c593c

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Merge branch 'adsk_contrib/add-support-for-minimum-and-recommended-ve…

9868861

…rsions-for-dependencies' of https://github.com/autodesk-forks/OpenColorIO into adsk_contrib/add-support-for-minimum-and-recommended-versions-for-dependencies

Fixing typo

912c9d6

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Mostly comments and documentations

f851ae5

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Small update of the Existing Install Hints section

376522f

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Changed RECOMMENDED_MIN_VERSION to RECOMMENDED_VERSION

8e0d5f9

Re-worded some of the comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Fixing issue with ocio_handle_dependency macro where it wasn't respec…

7faf3d5

…ting OCIO_INSTALL_EXT_PACKAGES option correctly. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Adding more documentations and dropping support to look for static zl…

462a10f

…ib since the user can update their cmake in order to do that. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Documentations

3c31486

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Documentations

9f4baf7

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

fixing typo

040e2b3

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

Fix typoe and fix issue when OCIO is installing ZLIB

67af4e0

Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>

cedrik-fuoco-adsk mentioned this pull request Mar 9, 2023

Adsk contrib - Add support for minimum and recommended versions for dependencies #1777

Merged

cedrik-fuoco-adsk closed this Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adsk contrib - Add support for minimum and recommended versions for dependencies#1772

Adsk contrib - Add support for minimum and recommended versions for dependencies#1772
cedrik-fuoco-adsk wants to merge 53 commits into
AcademySoftwareFoundation:mainfrom
autodesk-forks:adsk_contrib/add-support-for-minimum-and-recommended-versions-for-dependencies

cedrik-fuoco-adsk commented Feb 23, 2023 •

edited by doug-walker

Loading

Uh oh!

Uh oh!

cedrik-fuoco-adsk commented Mar 8, 2023 •

edited

Loading

Uh oh!

remia left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cedrik-fuoco-adsk commented Mar 9, 2023

Uh oh!

cedrik-fuoco-adsk commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

cedrik-fuoco-adsk commented Feb 23, 2023 • edited by doug-walker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cedrik-fuoco-adsk commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

remia left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cedrik-fuoco-adsk commented Mar 9, 2023

Uh oh!

cedrik-fuoco-adsk commented Mar 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cedrik-fuoco-adsk commented Feb 23, 2023 •

edited by doug-walker

Loading

cedrik-fuoco-adsk commented Mar 8, 2023 •

edited

Loading

remia left a comment •

edited

Loading