Adsk Contrib - Fix warning/errors log in unit test#1786
Merged
doug-walker merged 8 commits intoMay 4, 2023
Merged
Conversation
Fix OpenColorIO errors that was introduced a while ago in the unit test because of requirement for config. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Other warnings are not muted anymore when we check for role warnings. Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Changing some misuses of StartsWith Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Mute log from built-in config test Comments Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…ile not muting all logs (C++ side) Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…ad of just the line to find Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
remia
approved these changes
May 2, 2023
doug-walker
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the display of warning/error logs in the unit test. These logs were introduced in OCIO 2.2 because we added new requirements that require some roles to be present.
These logs should not be displayed in the unit test since they are expected in those specific tests. I've added some utility functions to mute and/or check those logs to confirm if they are present or not).