Do not assume minizip-ng uses zlib for compression#1796
Do not assume minizip-ng uses zlib for compression#1796MarcusCalhoun-Lopez wants to merge 1 commit into
Conversation
The file mz_strm_zlib.h does not exist if minizip-ng enables compression via means other than zlib. Since none of the functions provided by mz_strm_zlib.h are used (mz_stream_zlib_*), it can be safely removed.
|
|
|
Thanks for the contribution @MarcusCalhoun-Lopez. Could you resolve the DCO and EasyCLA issues? The PR needs that to be accepted. Thanks! |
Thank you for the reminder. |
|
Thank you for fixing the EasyCLA. It seems like the DCO is still failing because one of the commit is not signed. Thanks! |
|
Thanks for the suggestion @MarcusCalhoun-Lopez , Cedrik and I agree this is a good fix and we will incorporate it into a future PR. |
|
Thanks for the PR @MarcusCalhoun-Lopez, as there was still a DCO issue we couldn't merge this but the fix is included in #1902 which was just merged. I'm going to close this one then. |
The file mz_strm_zlib.h does not exist if minizip-ng enables compression via means other than zlib.
Since none of the functions provided by mz_strm_zlib.h are used (mz_stream_zlib_*), it can be safely removed.