Adsk contrib - Fix issue with urllib3 version and the container images for the CIs#1797
Merged
Conversation
cedrik-fuoco-adsk
force-pushed
the
adsk_contrib/fix-issue-with-sphinx-and-urllib3-in-workflow
branch
from
97c2d88 to
4dc19dd
Compare
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
…his is not compatible with the OCIO container images Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
remia
approved these changes
May 13, 2023
michdolan
approved these changes
May 15, 2023
doug-walker
deleted the
adsk_contrib/fix-issue-with-sphinx-and-urllib3-in-workflow
branch
doug-walker
pushed a commit
to autodesk-forks/OpenColorIO
that referenced
this pull request
Dec 6, 2023
…s for the CIs (AcademySoftwareFoundation#1797) * Changed OCIO_PYTHON_LOAD_DLLS_FROM_PATH to opt-in instead of opt-out Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Restrict the version of urllib3 to version <2 because version above this is not compatible with the OCIO container images Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> * Revert unwanted change from this branch Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> --------- Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com> Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes the issue with the CI and Dependencies latest workflow.
Since we don't control the versions of the Python modules for documentation, it is installing the latest version. Unfortunately, in OCIO's CentOS container images, the latest Urllib3 is not compatible with the OpenSSL version installed in those container images.