ocioview image and PySide6 updates#1912
Conversation
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
…nColorIO into feature/ocioview_3
remia
left a comment
remia
left a comment
There was a problem hiding this comment.
Thanks for fixing the issue @michdolan, looks good to me and confirm it works fine on mac OS.
KelSolaar
left a comment
KelSolaar
left a comment
There was a problem hiding this comment.
LGTM, only a minor comment about maybe using properties in the MessageRouter class.
| def image_updates_allowed(self) -> bool: | ||
| return self._image_updates_allowed | ||
|
|
||
| def set_image_updates_allowed(self, allowed: bool) -> None: | ||
| self._image_updates_allowed = allowed | ||
| if allowed and self._prev_image_array is not None: | ||
| # Rebroadcast last image record | ||
| message_queue.put_nowait(self._prev_image_array) | ||
|
|
||
| def processor_updates_allowed(self) -> bool: | ||
| return self._processor_updates_allowed | ||
|
|
||
| def set_processor_updates_allowed(self, allowed: bool) -> None: | ||
| self._processor_updates_allowed = allowed | ||
| if allowed and self._prev_config is not None: | ||
| # Rebroadcast last config record | ||
| message_queue.put_nowait(self._prev_config) |
There was a problem hiding this comment.
Shall we use properties here?
@property
def image_updates_allowed(self) -> bool:
return self._image_updates_allowed
@image_updates_allowed.setter
def image_updates_allowed(self, allowed: bool) -> None:
self._image_updates_allowed = allowed
if allowed and self._prev_image_array is not None:
# Rebroadcast last image record
message_queue.put_nowait(self._prev_image_array)There was a problem hiding this comment.
Good point. I will address this in a future PR
|
@michdolan , should we go ahead and merge this? |
|
@remia thoughts on the CI failure I'm getting since updating the base? It's related to CMake, but this work only changed Python files internal to |
I haven't time to investigate properly this week but it seems like the issue we have in #1964 ? I didn't see the error as the job was in canceled state today, I relaunched it and it now passes so this might have been fixed with a CMake update. |
4 participants
This PR makes the following changes to
ocioview: