Add ociocpuinfo utility #1960
Merged
doug-walker merged 3 commits intoApr 2, 2024
Merged
Conversation
Remove unneeded duplicate code h Handle unknown processors Signed-off-by: Mark Reid <mindmark@gmail.com>
Signed-off-by: Mark Reid <mindmark@gmail.com>
remia
approved these changes
Mar 27, 2024
Collaborator
remia
left a comment
remia
left a comment
There was a problem hiding this comment.
Thank you @markreidvfx, looks good to me. I assume we should make it available through the Python wheel? Should be as simple as adding it to the list here.
doug-walker
approved these changes
Mar 29, 2024
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Thanks Mark! Will hold off on merging to see if you want to add it to the Wheel as Remi suggested.
Contributor
Author
|
Yes, please hold off. I will add the executable to the wheel like remi suggested. |
Signed-off-by: Mark Reid <mindmark@gmail.com>
doug-walker
approved these changes
Mar 30, 2024
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Thanks, will merge after Remi's approval.
Collaborator
|
Thanks @markreidvfx, tested on the macOS wheel and it seem to work just fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a very simple utility that prints out the cpu features detected by OCIO.
This mimics the output of the program shared in #1935 and here.
implements #1937
It is with all the other ocio apps, wasn't sure if this was the best place to put it. I could see being with the test apps too.
I also took the time to simplify the CPUInfo header. There isn't really a need to special case aarch64. We can remove some duplicate code.