build(windows): Do not try to build minizip before zlib.

[MrSoup678]

No description provided.

[doug-walker]

@SlawekNowy , thanks for the PR. Would you please provide more detail about what scenarios require this fix? In other words, most Windows builds succeed already without this, so it must be something more specific about the way you are building.

[MrSoup678]

This is the local windows build. Fetched the repository and built it using Visual Studio generator. Both minizip and zlib are managed by opencolorio. Visual studio 2022 Community x64.

[MrSoup678]

Oh. I forgot to mention I run --parallel at cmake build step.

Also it seems that did not fix my problems?

[MrSoup678]

The build is done using cmake .. from build directory (from ocio dir), and then building generated project.

[MrSoup678]

I'll admit this is not standard setup, but this repo's CMakeLists does fetch deps...
And besides that is standard setup on Linux...

[MrSoup678]

From parent project's discord:

ok cmake. You get a race condition without the deps' root set, but you don't if I do set the root directories of deps? what?

[stephen-yee-adsk]

Hi Slawek,

I encountered the same problem on Windows. It seems that minizip-ng sometimes builds before zlib, which causes a build error, because minizip-ng depends on zlib. I was able to fix it locally by adding a dependency on Zlib in the ExternalProject_add call in Installminizip-ng.cmake.

i.e.

    ExternalProject_Add(minizip-ng_install
        GIT_REPOSITORY "https://github.com/zlib-ng/minizip-ng.git"
        GIT_TAG "${minizip-ng_VERSION}"
        GIT_CONFIG advice.detachedHead=false
        GIT_SHALLOW TRUE
        PREFIX "${_EXT_BUILD_ROOT}/libminizip-ng"
        BUILD_BYPRODUCTS ${minizip-ng_LIBRARY}
        CMAKE_ARGS ${minizip-ng_CMAKE_ARGS}
        EXCLUDE_FROM_ALL TRUE
        BUILD_COMMAND ""
        INSTALL_COMMAND
            ${CMAKE_COMMAND} --build .
                            --config ${CMAKE_BUILD_TYPE}
                            --target install
                            --parallel
        DEPENDS ZLIB::ZLIB        # minizip-ng depends on zlib
    )

Could you try this and see if it fixes your build?

[MrSoup678]

@stephen-yee-adsk Confirmed fixed, by project head.

[doug-walker]

@SlawekNowy , thanks for the update, the code looks perfect now, but unfortunately it looks like you did not sign your latest commit? The DCO sign-off check needs to pass before we're able to merge it. Usually "git commit --amend -s" and then re-pushing will fix it.

[MrSoup678]

Closing in favor of #1986.