Skip to content

build(windows):Add msvs parameter to ocio_deps.bat for ocio.bat argument parity#1974

Closed
MrSoup678 wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
MrSoup678:ocio_deps_parity
Closed

build(windows):Add msvs parameter to ocio_deps.bat for ocio.bat argument parity#1974
MrSoup678 wants to merge 1 commit into
AcademySoftwareFoundation:mainfrom
MrSoup678:ocio_deps_parity

Conversation

@MrSoup678
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Sławomir Śpiewak <sosw.slawomir.spiewak@gmail.com>
Comment thread share/dev/windows/ocio_deps.bat
@MrSoup678 MrSoup678 changed the title build(windows):Add msvs parameter to ocio_deps.bat for ocio.bat parity build(windows):Add msvs parameter to ocio_deps.bat for ocio.bat argument parity May 27, 2024
@MrSoup678 MrSoup678 requested a review from remia June 12, 2024 15:49
@remia
Copy link
Copy Markdown
Collaborator

remia commented Jul 1, 2024

Looks good to me, will let someone that has Windows access test it though, thanks @SlawekNowy.

Missed that but this PR might be superseded by #1980 ?

@MrSoup678
Copy link
Copy Markdown
Contributor Author

Might be, thing is nowadays we would be using vswhere either way.
Closing in favor to #1980.

@MrSoup678 MrSoup678 closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants