Updated documentation Specifying types for GradingPrimary attributes #1640#1989
Merged
doug-walker merged 4 commits intoAug 9, 2024
Merged
Conversation
Signed-off-by: sumana sree <sumanasree2705@gmail.com>
sumana-2705
changed the title
doug-walker
approved these changes
Jul 5, 2024
cozdas
reviewed
Jul 22, 2024
Collaborator
cozdas
left a comment
cozdas
left a comment
There was a problem hiding this comment.
Do we want to include pivotWhite and pivotBlack in the list as well?
Contributor
Author
|
While I was running initial tests mentioned in the issue, it did not mention pivotWhite and pivotBlack, which is why they were not included in my first response. However, considering your feedback, I think it is reasonable to assume that these properties also follow the pattern observed for similar properties like |
Signed-off-by: sumana sree <sumanasree2705@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Documentation: Specify Types for GradingPrimary Attributes
Description:
This pull request updates the documentation for the GradingPrimary class in OpenColorIO to specify the expected types for its attributes, enhancing clarity for developers mentioned in the issue #1640
Changes Made:
Added type specifications for the following attributes:
GradingRGBMfloatfloatGradingRGBMGradingRGBMGradingRGBMGradingRGBMGradingRGBMGradingRGBMfloatfloat