ocioview: app mode, tests, color space menus, bug fixes#2006
Conversation
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
Signed-off-by: Michael Dolan <michdolan@gmail.com>
|
Note: I ran |
Signed-off-by: Michael Dolan <michdolan@gmail.com>
| app: Optional[QtWidgets.QApplication] = None, | ||
| ) -> QtWidgets.QApplication: | ||
| """Create and configure QApplication.""" | ||
| # Setup environment |
There was a problem hiding this comment.
As discussed on Slack, we should probably disable the native macOs menu here otherwise the new Preview mode button does not show:
# Disabling macOs native menus
QtCore.QCoreApplication.setAttribute(QtCore.Qt.AA_DontUseNativeMenuBar)There was a problem hiding this comment.
(We will have to fiddle with menu text alignment a bit but it does work this way at least.)
Signed-off-by: Michael Dolan <michdolan@gmail.com>
|
I recombined the viewer types which I had previously split out per application mode, so now there is one viewer widget which adapts to the current mode. This should resolve issues with loaded images behaving inconsistently when switching mode. |
|
Tested, it works for me! |

This PR includes the following list of
ocioviewupdates:Add "Application Mode" with two options:


EditandPreview.Editis the default mode, which provides the existing config authoring interface.Previewis a new mode for previewing the config in a UX reference integration. This PR includes a new preview viewer with a standard display/view selection interface, which is currently the only change when switching toPreviewmode. Future work will add new interfaces for demonstrating OCIO UX best practices and for validating config behavior in a typical DCC. ThePreviewmode is being designed by the UX Working Group.Add unit testing framework that leverages

pytestandpytest-qtfor automated testing of theocioviewapplication. This PR includes three initial tests for the color space edit interface to prove its functionality, but there remains much work to do in building out a test suite for broader coverage, which I think is what this application will need to be out of beta.Add new color space combo box which leverages

ColorSpaceMenuHelperto provide color spaces organized by family, along with color space roles. This new widget replaces all color space selection throughout the application, and will be used in the newPreviewmode to illustrate different color space selection use cases.Add a
SignalRouterinterface for fast application-wide thread-safe communication of specific config changes, like when color spaces or roles change, or when the config is reloaded. This router doesn't route any message content like theMessgeRouter, making it simpler and more performant. Both have useful application, but the new router will likely grow in scope while the message router focuses on cases where data needs to be modified in a thread before being delivered to subscribers.Several bug fixes and stability improvements.
There is much more work to do on some of these new features, but this update aims to complete some foundational work for these changes.