Add hasAlias method to ColorSpace and NamedTransform classes#2059
Merged
Conversation
doug-walker
requested changes
Sep 26, 2024
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
This is great work Annie! Really nice job on the unit tests!
There is one other part necessary so that the new method shows up in the Python binding too. Please update the files:
OpenColorIO/src/bindings/python/PyColorSpace.cpp
OpenColorIO/src/bindings/python/PyNamedTransform.cpp
OpenColorIO/tests/python/ColorSpaceTest.py
OpenColorIO/tests/python/NamedTransformTest.py
The syntax using for the Python bindings (pybind11) is a bit arcane, but you should be able to copy what you see for the other methods. Let us know if you have a question.
Signed-off-by: annie <annieyhlin09@gmail.com>
Signed-off-by: annie <annieyhlin09@gmail.com>
Signed-off-by: annie <annieyhlin09@gmail.com>
doug-walker
approved these changes
Sep 27, 2024
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
This is excellent work, thank you so much Annie!
KelSolaar
approved these changes
Sep 27, 2024
| def test_aliases(self): | ||
| """ | ||
| Test NamedTransform aliases. | ||
| Test ColorSpace aliases. |
chrisnashdisguise
pushed a commit
to chrisnashdisguise/OpenColorIO
that referenced
this pull request
Oct 30, 2024
…SoftwareFoundation#2059) * Add hasAlias method to ColorSpace and NamedTransform classes Signed-off-by: annie <annieyhlin09@gmail.com> * minor style changes Signed-off-by: annie <annieyhlin09@gmail.com> * Update Python binding to include hasAlias method with unit tests Signed-off-by: annie <annieyhlin09@gmail.com> --------- Signed-off-by: annie <annieyhlin09@gmail.com> Signed-off-by: Chris Nash <chris.nash@disguise.one>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2047