Adsk Contrib - Vulkan support#2176
Conversation
|
As requested, here is my feedback on the PR (forked the branch to check the code).
so for direct3d an additional samplerBindingStart is required. Also note that registers in Direct3d are zero indexed
There is another function in GpuShaderCreator called :
This is off by default and keeps explicit implementations to use the default "automatic" bindings" (eg : current implementation) , and use explicit as an Opt-In.
becomes :
It would require a new enum in that case GPU_LANGUAGE_HLSL_SM_5_1 But given that it would not break the GpuCreator interface, this could be implemented at a later stage with no risk of breaking existing implementations. |
e3260da to
c80e919
Compare
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
…tart index. Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Co-authored-by: Aleksi Sapon <aleksi.sapon@autodesk.com> Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
c80e919 to
77756ec
Compare
cozdas
left a comment
There was a problem hiding this comment.
Just needs the broken Windows unit tests fixed. Otherwise LGTM!
Signed-off-by: Michael Horsch <michael.horsch@autodesk.com>
doug-walker
left a comment
There was a problem hiding this comment.
This is a very welcome feature, thank you so much @michaelHADSK !
This PR adds Vulkan support to OCIO.