deps: Add build recipe for GIF - #4653
Conversation
Signed-off-by: Sergio Rojas <sergiorojasava@gmail.com>
5d3962a to
34ba540
Compare
|
How did you test this and verify that it works? |
|
I'm still working on the pull request - Here's what I'm currently doing to test and verify the CMake files:
This makes CMake to build all dependencies locally instead of using system-installed versions. |
|
Another way to test and verify:
a. Converting an image to GIF format: b. You can also try to convert a GIF to another format to further verify that it's working: |
| PATCH_COMMAND | ||
| curl -L https://sourceforge.net/p/giflib/bugs/_discuss/thread/4e811ad29b/c323/attachment/Makefile.patch -o Makefile.patch && | ||
| patch -p0 < Makefile.patch |
There was a problem hiding this comment.
Should we be bothered by the fact that the build_dependency_with_cmake function doesn't take a "PATCH_COMMAND" argument, and so this extra patch won't be applied?
There was a problem hiding this comment.
Also, build_dependency_with_cmake doesn't take a URL or URL_HASH argument, and in fact the only kind of download it knows how to do is to clone a git repo? I just don't understand how the code as presented here can work.
Are you sure you aren't locally running and testing a version of this patch that is different from the one currently in this PR?
This hypothesis is also supported by the fact that the screenshots you attached have messages about FetchContent, which we do not call anywhere and also aren't mentioned in this patch.
There was a problem hiding this comment.
just realized I forgot to push my latest change where I removed the build_dependency_with_cmake method since it only accepts a git repository
fdd1f0c to
0f7a559
Compare
|
This PR has been idling for a while, I think because it never quite passed CI. Is this something you're going to return to, @hisergiorojas? Maybe we should start by rebasing it on top of the current main and see what, if anything, is still broken? |
|
Closing. This never fully passed CI, the PR has sat idle for months without the author fixing it, and in the mean time, somebody else has fully implemented it in #4921. Sincere thanks for trying to implement this; it's ok, not all PRs work out. The effort is appreciated. |


Description
As requested in #4387.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.