feat(heif): Monochrome channel read and write support, fix crash - #5043
Merged
Conversation
Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously Writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image. Destroy m_ctx on exception to prevent that. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
brechtvl
force-pushed
the
fix-heif-mono
branch
from
February 12, 2026 03:00
a274f0a to
2f0157d
Compare
lgritz
approved these changes
Feb 13, 2026
lgritz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, and I'm going to amend a small docs fix if you don't mind.
Collaborator
|
I took the liberty of pushing a minor documentation patch to your fork. Can you look it over and be sure it seems fine to you? Then I will merge. |
Contributor
Author
|
Thanks, looks good. |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 15, 2026
…demySoftwareFoundation#5043) Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image and crash. Destroy m_ctx on exception to prevent that for other potential errors. Test added for monochrome read and write. --------- Signed-off-by: Brecht Van Lommel <brecht@blender.org>
ssh4net
pushed a commit
to ssh4net/OpenImageIO
that referenced
this pull request
Feb 24, 2026
…demySoftwareFoundation#5043) Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image and crash. Destroy m_ctx on exception to prevent that for other potential errors. Test added for monochrome read and write. --------- Signed-off-by: Brecht Van Lommel <brecht@blender.org> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net
pushed a commit
to ssh4net/OpenImageIO
that referenced
this pull request
Apr 1, 2026
…demySoftwareFoundation#5043) Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image and crash. Destroy m_ctx on exception to prevent that for other potential errors. Test added for monochrome read and write. --------- Signed-off-by: Brecht Van Lommel <brecht@blender.org> Signed-off-by: Vlad <shaamaan@gmail.com>
ssh4net
pushed a commit
to ssh4net/OpenImageIO
that referenced
this pull request
Apr 2, 2026
…demySoftwareFoundation#5043) Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image and crash. Destroy m_ctx on exception to prevent that for other potential errors. Test added for monochrome read and write. --------- Signed-off-by: Brecht Van Lommel <brecht@blender.org> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net
pushed a commit
to ssh4net/OpenImageIO
that referenced
this pull request
Apr 2, 2026
…demySoftwareFoundation#5043) Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image and crash. Destroy m_ctx on exception to prevent that for other potential errors. Test added for monochrome read and write. --------- Signed-off-by: Brecht Van Lommel <brecht@blender.org> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com>
ssh4net
pushed a commit
to ssh4net/OpenImageIO
that referenced
this pull request
Apr 2, 2026
…demySoftwareFoundation#5043) Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image and crash. Destroy m_ctx on exception to prevent that for other potential errors. Test added for monochrome read and write. --------- Signed-off-by: Brecht Van Lommel <brecht@blender.org> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com> Signed-off-by: Vlad <shaamaan@gmail.com>
ssh4net
pushed a commit
to ssh4net/OpenImageIO
that referenced
this pull request
Apr 2, 2026
…demySoftwareFoundation#5043) Implement support for reading and writing monochrome. Reading requires libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace. Previously writing a single channel image would cause an exception due to wrong parameters, but close() would continue writing the image and crash. Destroy m_ctx on exception to prevent that for other potential errors. Test added for monochrome read and write. --------- Signed-off-by: Brecht Van Lommel <brecht@blender.org> Signed-off-by: Vlad (Kuzmin) Erium <libalias@gmail.com> Signed-off-by: Vlad <shaamaan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement support for reading and writing monochrome. Reading requires
libheif 1.17+ for heif_image_handle_get_preferred_decoding_colorspace.
Previously writing a single channel image would cause an exception due to
wrong parameters, but close() would continue writing the image and crash.
Destroy m_ctx on exception to prevent that for other potential errors.
Tests
Test added for monochrome read and write.
Checklist:
behavior.
testsuite.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.