fix(sgi): Better detection of corrupt RLE info that could overflow - #5141
Merged
Conversation
lgritz
commented
Apr 11, 2026
lgritz
commented
Collaborator
- Change DASSERTs (which were correct, but did not enforce anything in release builds) into real checks that will return error messages and flags if the corruptions are found.
- Switch to using spans for extra checks if anything goes wrong.
- Use check_open.
- Check that various header items are valid enum values.
* Change DASSERTs (which were correct, but did not enforce anything in release builds) into real checks that will return error messages and flags if the corruptions are found. * Switch to using spans for extra checks if anything goes wrong. * Use check_open. * Check that various header items are valid enum values. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added
bug
jessey-git
approved these changes
Apr 15, 2026
jessey-git
left a comment
jessey-git
left a comment
Contributor
There was a problem hiding this comment.
Looks good and tests out well locally.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 19, 2026
…cademySoftwareFoundation#5141) * Change DASSERTs (which were correct, but did not enforce anything in release builds) into real checks that will return error messages and flags if the corruptions are found. * Switch to using spans for extra checks if anything goes wrong. * Use check_open. * Check that various header items are valid enum values. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 19, 2026
…cademySoftwareFoundation#5141) * Change DASSERTs (which were correct, but did not enforce anything in release builds) into real checks that will return error messages and flags if the corruptions are found. * Switch to using spans for extra checks if anything goes wrong. * Use check_open. * Check that various header items are valid enum values. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 19, 2026
…cademySoftwareFoundation#5141) * Change DASSERTs (which were correct, but did not enforce anything in release builds) into real checks that will return error messages and flags if the corruptions are found. * Switch to using spans for extra checks if anything goes wrong. * Use check_open. * Check that various header items are valid enum values. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 19, 2026
…cademySoftwareFoundation#5141) * Change DASSERTs (which were correct, but did not enforce anything in release builds) into real checks that will return error messages and flags if the corruptions are found. * Switch to using spans for extra checks if anything goes wrong. * Use check_open. * Check that various header items are valid enum values. Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Apr 19, 2026
…cademySoftwareFoundation#5141) * Change DASSERTs (which were correct, but did not enforce anything in release builds) into real checks that will return error messages and flags if the corruptions are found. * Switch to using spans for extra checks if anything goes wrong. * Use check_open. * Check that various header items are valid enum values. Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.