Skip to content

fix issue adop-sonar#11#29

Merged
SachinKSingh28 merged 1 commit intoAccenture:masterfrom
m4m51m:feature/fix_issues_11_sonar
Sep 22, 2017
Merged

fix issue adop-sonar#11#29
SachinKSingh28 merged 1 commit intoAccenture:masterfrom
m4m51m:feature/fix_issues_11_sonar

Conversation

@m4m51m
Copy link

@m4m51m m4m51m commented Dec 11, 2016

Fix for #25

@svscorp
Copy link
Contributor

svscorp commented Aug 28, 2017

@nickdgriffin @anton-kasperovich @SachinKSingh28

Hi team, we validated this fix partially - line 71 location ^~ /sonar { does make sonar work. Though, changes on lines 45..72 are being checked by @mlushpenko

@m4m51m can you please comment why 45..72 are present in the fix? Also, can you please split the PR to two, one for SonarQube actual fix another for 45..72? I believe we can merge it faster if looks good for the team.

Thank you.

@svscorp
Copy link
Contributor

svscorp commented Aug 28, 2017

Ok, we checked second part of the PR and status page is not working (at least on existing stable platform), maybe if @m4m51m can comment what 45..72 is there for it will be more clear.

update 29th of August: works good!

mlushpenko pushed a commit to mlushpenko/adop-nginx that referenced this pull request Aug 28, 2017
@mlushpenko
Copy link

mlushpenko commented Aug 28, 2017

@m4m51m My bad, it is working - it fixes status page

image

@SachinKSingh28
Copy link
Contributor

I have tested this changes and issue is fixed.

Steps below -

  • Created a new image from feature/fix_issues_11_sonar branch on m4m51m/adop-nginx
  • Updated docker compose file from adop-docker-compose repository with new tag for adop-nginx image used adop-sonar image 0.3.4
  • Launched ADOP stack.

@svscorp
Copy link
Contributor

svscorp commented Sep 25, 2017

Thanks, @SachinKSingh28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants