Skip to content

fix(lsp): send workspace folders during initialization - #2623

Merged
bajrangCoder merged 2 commits into
mainfrom
fix/python-lsp-workspace-folders
Aug 4, 2026
Merged

fix(lsp): send workspace folders during initialization#2623
bajrangCoder merged 2 commits into
mainfrom
fix/python-lsp-workspace-folders

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

Pass the resolved workspace root through initialize.workspaceFolders so language servers such as ty can discover project configuration and Python virtual environments.

Pass the resolved workspace root through initialize.workspaceFolders so
language servers such as ty can discover project configuration and Python
virtual environments.
@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR completes the LSP workspace-root initialization fix by passing resolved roots in initialize.workspaceFolders for document-scoped clients while preserving dynamic folder registration for shared workspace clients.

  • Adds workspaceFolders capability and initialization payload support.
  • Derives a readable workspace name from the resolved root URI.
  • Makes root logging explicit after initialization.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/cm/lsp/clientManager.ts Correctly aligns initialization-time workspace-folder injection with the existing scope-aware dynamic workspace-folder lifecycle.

Reviews (2): Last reviewed commit: "fix" | Re-trigger Greptile

Comment thread src/cm/lsp/clientManager.ts Outdated
@bajrangCoder

This comment was marked as outdated.

@bajrangCoder
bajrangCoder merged commit 30877ec into main Aug 4, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Aug 4, 2026
@bajrangCoder
bajrangCoder deleted the fix/python-lsp-workspace-folders branch August 4, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant