feat(ui) introducing an lsp menu dialog to fit more features than just codeactions - #2702
Open
gat0sy wants to merge 4 commits into
Open
feat(ui) introducing an lsp menu dialog to fit more features than just codeactions#2702gat0sy wants to merge 4 commits into
gat0sy wants to merge 4 commits into
Conversation
Contributor
Greptile SummaryThe PR introduces a consolidated LSP actions menu and expands editor navigation, reference, rename, code-action, tooltip-link, and workspace-edit support.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains from the previously reported issues. The menu now aggregates capabilities across attached clients and go-to operations select a supporting client, while workspace edits accumulate duplicate URI groups rather than overwriting earlier groups; no blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Button[LSP actions button] --> Menu[LSP actions menu]
Menu --> Capability[Select supporting LSP client]
Capability --> Navigation[Definitions and references]
Capability --> Rename[Rename symbol]
Capability --> Actions[Code actions]
Actions --> WorkspaceEdit[Apply workspace edits]
Reviews (2): Last reviewed commit: "feat(editor): resolve LSP file:// URIs a..." | Re-trigger Greptile |
LspToPosition threw range error on format error. We attempt to fix it here with by clamping so we get the correct line count between the client and server. applyTextEdit as also been extracted so both transport and client manager can import it from the helper.
LspToPosition threw range error on format error. We attempt to fix it here with by clamping so we get the correct line count between the client and server. applyTextEdit as also been extracted so both transport and client manager can import it from the helper.
go to def and similar fonction have been added, a new interceptFileLink method has been created to solve an FileUriExposedException you may get if taping the signature link on the hover. if the link is a website, it skips and let the normal behavior occur ( open a web browser page ) if the link is a file, it modifies the uri so the tap behave like a go to instead of crashing the whole app. There are notably also some fixes for code actions, rename...ect, now they use the new lspPostionToOffset that uses clamping
…actions menu Added resolveContentUriForFileUri() to map LSP file:// responses back to content:// and sftp:// URIs via addedFolder matching Refactor editorManager displayFile/openFile to resolve URIs before opening, enabling cross-workspace go-to-definition and references Added SFTP path-aware root URI resolution for remote workspace context Replace selection menu code-actions button with full LSP actions menu (definition, declaration, implementation, type-definition, references, rename, code-actions) with single-item auto-execution
gat0sy
force-pushed
the
feat/lsp-ui-integration
branch
from
August 10, 2026 05:19
2b6f880 to
32b9957
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated LSP actions menu to the editor.
The tooltip button now opens the new LSP menu instead of directly showing code actions. Code actions have been moved into this menu alongside the other go-to actions.
The menu provides quick access to:
Single-result actions are executed directly without opening the menu.
This PR is based on PR #2701