Remove request library#60
Conversation
|
@ibalosh another option to evaluate is 3.84MB: https://packagephobia.now.sh/result?p=request huge improvement, either way! |
|
i should add that i was considering moving our transactional emails to postmark until i looked at the lib size and compared it to using our own smtp servers with nodemailer: 4.09MB: https://packagephobia.now.sh/result?p=postmark this change would definitely put postmark back in the running for me. |
|
thats good to hear @leeoniya , update should be released in next couple of days |
tomazy
left a comment
tomazy
left a comment
There was a problem hiding this comment.
@ibalosh functionally it seems to work as before (however I haven't managed to run all the tests as green) so I think this is fine.
I usually try not to test private stuff so I"m not happy about those tests, but I see you mostly adjusted them to the new way of handling the requests so I guess we could think about improving this part on another occasion.
I've also left some stylistic suggestions but I leave it to you whether to apply them or not - they may interfere with the existing style of this project.
|
Hey @tomazy , big thanks for code review. I implemented all the suggestions you made, they were all great! |
3 participants
Hey @tomazy
could you take a quick look on this branch? Would love a pair of eyes to run through it even though its a small update, but touches main aspect of requests handling.
The update is related to http client library. RequestJS got deprecated. Due to popularity, ease of use, size, decided to go for axios.
Along the road error handling and tests were cleaned up a bit.