Skip to content

Add short-circuit exact-match comparison #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swagile1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add short-circuit exact-match comparison #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add short-circuit exact-match comparison
  • Loading branch information
@swagile1
swagile1 committed Mar 13, 2023
commit d5c8f8aeebb58b00a6679da109225c933f1e7fcf
5 changes: 5 additions & 0 deletions pkg/version/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@ var bigZero = decimal.New(0, 0)
// Versions that differ only by trailing zeros (e.g. "1.2" and "1.2.0") are
// equal.
func Compare(v1, v2 *Version) int {
// if they're the same pointer, the versions are equal
if v1 == v2 {
return 0
}

min, max, longest, flip := minMax(v1.Decimal, v2.Decimal)

// find any difference between these versions where they have the same number of segments
Expand Down