Re-land #283 unlocks (Quantum, Disambiguator, verb_table, animal-farm harness) — orphaned by merge order#285
Conversation
…ce + 144-cell verb table
…m mode + Animal Farm harness
… + quantum_mode + PhaseTag fix - Re-exported VerbFamily, VerbRoleTable, SlotPrior, default_table from grammar/mod.rs - Re-exported Disambiguatable, GeneralizedResult, disambiguate_general - Added pub mod trajectory_audit + pub mod quantum_mode in deepnsm/lib.rs - Fixed PhaseTag from_angle/to_angle: u128::MAX as f32 was overflowing to infinity, producing NaN on round-trip. Switched to f64 intermediate and use only the low 64 bits (high 64 reserved for future precision)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f1745969f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub fn pi() -> Self { | ||
| PhaseTag(u128::MAX / 2) |
There was a problem hiding this comment.
Encode π from the low 64-bit phase domain
to_angle decodes only the low 64 bits of PhaseTag, but pi() sets the full 128-bit value to u128::MAX / 2; that makes the low half u64::MAX, so PhaseTag::pi().to_angle() resolves to ~TAU (2π), not π. Any caller using pi() as a canonical half-turn phase will get the wrong phase offset and distance behavior. pi() should be derived from the same low-half mapping as from_angle (or set low bits to ~u64::MAX / 2).
Useful? React with 👍 / 👎.
Why this PR exists
PR #283 was marked merged but the unlock content never landed on
main. The merge order on 2026-04-29 was:#283 landed on the orphaned branch tip
7d7b7224, which is no longer reachable from main. The three unlock commits sit there with nowhere to go.This PR brings that content forward against the current
main. No content change vs the original #283 — same three commits, same +845 / -22 footprint across 9 files.What's wired
B-unlock-yaml-style(bbb9898) — YAML robustness +Instrumentvariant + persistence + 144-cell verb taxonomy tableB-unlock-bridge(30e43f8) —Trajectoryaudit-hash bridge + generalisedDisambiguatortrait + Quantum mode (PhaseTag+HolographicMode) + Animal Farm forward-validation harnessB-META R2 unlocks(5f17459) — Wiresverb_table+disambiguator+trajectory_audit+quantum_modemodules + thePhaseTagu128::MAX as f32 → infinityoverflow fixFiles changed (vs current main)
Verification
git merge --no-commit --no-ffof branch onto current main → "Automatic merge went well", exit 0eeddfe9) and current main (218c2cf) — that window is empty (only the merge commit218c2cfitself, no source-file diffs)cargo checkand 382 tests greenCross-link
Generated by Claude Code
Generated by Claude Code