ci: revert ndarray-branch pin — PR #115 has landed on master#315
Merged
Conversation
PR #308 added a temporary `ref: claude/continue-lance-graph-ndarray-Ld786` pin to the lance-graph CI workflows because the symbols bgz-tensor / lance-graph-callcenter consume (wht_f32, kmeans, squared_l2, dequantize_i8_to_f32, quantize_f32_to_i2, dequantize_i2_to_f32) were not yet public on ndarray master. The TODO said to revert once ndarray PR #115 lands. ndarray PR #115 merged 2026-04-30 07:01:44 UTC. Verified the symbols are now reachable on master at: src/simd.rs (re-exports the public surface) src/hpc/cam_pq.rs (kmeans, squared_l2) src/hpc/fft.rs (wht_f32) src/hpc/quantized.rs (i8/i2 quantize/dequantize) Removes 4 occurrences of the pin (2 in rust-test.yml + 2 in style.yml, one per CI job that checks out ndarray as a sibling) and replaces the TODO with an explanatory comment that names the upstream PR + date so the next reader understands the history. Diff: +12 / -16 across 2 files. YAML still well-formed. No code change. No medcare-rs / smb-office-rs side effect. Cross-link: ndarray PR #115, lance-graph PR #308 (the original pin).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the temporary
ref: claude/continue-lance-graph-ndarray-Ld786pin that PR #308 added to both CI workflows. ndarray PR #115 has landed on master, exposing the public symbols the pin was waiting for.Triggering condition (verified)
The PR #308 TODO said:
AdaWorldAPI/ndarraymaster atwht_f32src/simd.rs,src/hpc/fft.rskmeans,squared_l2src/simd.rs,src/hpc/cam_pq.rsdequantize_i8_to_f32,quantize_f32_to_i2,dequantize_i2_to_f32src/simd.rs,src/hpc/quantized.rsndarray PR #115 merged 2026-04-30 07:01:44 UTC. The pin's purpose is fully discharged; keeping it would be a stale dependency that prevents the lance-graph CI from picking up subsequent ndarray fixes (e.g. ndarray PR #123's clippy resolutions, which were NOT on the pinned branch).
What changed
4 occurrences of the pin removed (one per CI job that checks out ndarray as a sibling):
.github/workflows/rust-test.yml× 2 jobs (lint-and-build, full-build).github/workflows/style.yml× 2 jobs (style, cargo-metadata)Each
# TODO: revert ...comment +ref:line is replaced with an explanatory comment naming the upstream PR + date, so the next reader sees the history not just an absent line.Verification
grep -rn 'claude/continue-lance-graph-ndarray-Ld786\|TODO: revert'→ cleanpython3 -c "import yaml; ..."→ both YAML files parse cleanlyWhat this PR does NOT do
Cross-link
Files changed
.github/workflows/rust-test.yml—+8 / −10.github/workflows/style.yml—+4 / −6Generated by Claude Code
Generated by Claude Code