Skip to content

ci: revert ndarray-branch pin — PR #115 has landed on master#315

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/ci-revert-ndarray-pin-L3DF0
Apr 30, 2026
Merged

ci: revert ndarray-branch pin — PR #115 has landed on master#315
AdaWorldAPI merged 1 commit into
mainfrom
claude/ci-revert-ndarray-pin-L3DF0

Conversation

@AdaWorldAPI
Copy link
Copy Markdown
Owner

Summary

Reverts the temporary ref: claude/continue-lance-graph-ndarray-Ld786 pin that PR #308 added to both CI workflows. ndarray PR #115 has landed on master, exposing the public symbols the pin was waiting for.

Triggering condition (verified)

The PR #308 TODO said:

TODO: revert to default branch once ndarray PR #115 lands (which exports wht_f32, kmeans, squared_l2, dequantize_i8_to_f32, quantize_f32_to_i2, dequantize_i2_to_f32 publicly).

Symbol Now on AdaWorldAPI/ndarray master at
wht_f32 src/simd.rs, src/hpc/fft.rs
kmeans, squared_l2 src/simd.rs, src/hpc/cam_pq.rs
dequantize_i8_to_f32, quantize_f32_to_i2, dequantize_i2_to_f32 src/simd.rs, src/hpc/quantized.rs

ndarray PR #115 merged 2026-04-30 07:01:44 UTC. The pin's purpose is fully discharged; keeping it would be a stale dependency that prevents the lance-graph CI from picking up subsequent ndarray fixes (e.g. ndarray PR #123's clippy resolutions, which were NOT on the pinned branch).

What changed

4 occurrences of the pin removed (one per CI job that checks out ndarray as a sibling):

  • .github/workflows/rust-test.yml × 2 jobs (lint-and-build, full-build)
  • .github/workflows/style.yml × 2 jobs (style, cargo-metadata)

Each # TODO: revert ... comment + ref: line is replaced with an explanatory comment naming the upstream PR + date, so the next reader sees the history not just an absent line.

Verification

  • grep -rn 'claude/continue-lance-graph-ndarray-Ld786\|TODO: revert' → clean
  • python3 -c "import yaml; ..." → both YAML files parse cleanly

What this PR does NOT do

  • No code change. The pin lived only in CI workflow files.
  • No effect on consumer crates (medcare-rs / smb-office-rs).
  • No version bump on ndarray-stats or any crate-level dep.

Cross-link

Files changed

  • .github/workflows/rust-test.yml+8 / −10
  • .github/workflows/style.yml+4 / −6

Generated by Claude Code


Generated by Claude Code

PR #308 added a temporary `ref: claude/continue-lance-graph-ndarray-Ld786`
pin to the lance-graph CI workflows because the symbols bgz-tensor /
lance-graph-callcenter consume (wht_f32, kmeans, squared_l2,
dequantize_i8_to_f32, quantize_f32_to_i2, dequantize_i2_to_f32) were
not yet public on ndarray master. The TODO said to revert once
ndarray PR #115 lands.

ndarray PR #115 merged 2026-04-30 07:01:44 UTC. Verified the symbols
are now reachable on master at:
  src/simd.rs            (re-exports the public surface)
  src/hpc/cam_pq.rs      (kmeans, squared_l2)
  src/hpc/fft.rs         (wht_f32)
  src/hpc/quantized.rs   (i8/i2 quantize/dequantize)

Removes 4 occurrences of the pin (2 in rust-test.yml + 2 in style.yml,
one per CI job that checks out ndarray as a sibling) and replaces the
TODO with an explanatory comment that names the upstream PR + date so
the next reader understands the history.

Diff: +12 / -16 across 2 files. YAML still well-formed.

No code change. No medcare-rs / smb-office-rs side effect.

Cross-link: ndarray PR #115, lance-graph PR #308 (the original pin).
@AdaWorldAPI AdaWorldAPI merged commit 8cac337 into main Apr 30, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant