style(shader-driver): drop double-space alignment in bindspace.rs comments#327
Merged
Merged
Conversation
…ments PR #323 introduced two trailing-comment alignments using two leading spaces ('PR_N // comment') instead of the surrounding file's single-space convention. rustfmt 1.94.1 collapses both back to a single space, so the file is one CI rustfmt invocation away from failing — the only thing keeping it green today is that cognitive-shader-driver isn't yet under any cargo fmt CI gate. Two surgical edits, no behaviour change: -pub const FLOATS_PER_VSA: usize = 16_384; // Vsa16kF32 carrier width +pub const FLOATS_PER_VSA: usize = 16_384; // Vsa16kF32 carrier width - pub cycle: Box<[f32]>, // was Box<[u64]>, now Vsa16kF32 carrier (16_384 f32 per row) + pub cycle: Box<[f32]>, // was Box<[u64]>, now Vsa16kF32 carrier (16_384 f32 per row) Surfaced during the post-merge code-review pass over PRs #322-#325. The file's other (pre-existing) one-line accessor styles are left untouched on purpose — those are the maintainers' chosen aesthetic and rustfmt would also expand them, so a full 'rustfmt --check' fix would mix scopes (taste-change vs drift-fix). Keeping this commit to drift-fix only. Co-authored-by: AdaWorldAPI <AdaWorldAPI@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Surfaced during the post-merge code-review pass over PRs #322 – #325. PR #323 introduced two trailing-comment alignments using two leading spaces (
PR_N // comment) instead of the surrounding file's single-space convention.rustfmt 1.94.1collapses both back to a single space, so the file is one CI rustfmt invocation away from failing — the only thing keeping it green today is thatcognitive-shader-driverisn't yet under anycargo fmtCI gate.Diff
Two lines, no behaviour change.
Why surgical, not
rustfmt --writeover the whole filerustfmt --checkagainst this file currently flags more than the two PR #323 lines: the file's pre-existing one-line accessorswould also be expanded across multiple lines. That's the maintainers' chosen aesthetic for the rest of the file (and the same style is used elsewhere in the crate); changing it is a taste decision, not a drift-fix. Keeping this PR to only the alignment drift PR #323 introduced lets the larger style question — including whether to put
cognitive-shader-driverunder a CI fmt gate at all — happen in its own decision window.Verification
cargo test --manifest-path crates/cognitive-shader-driver/Cargo.toml --lib bindspace— 12/12 pass.Companion PR
PR #326 (open) — fixes PR #322's
log_norm_growth_negative_when_m_attenuatestest that was broken at merge.