docs(knowledge+agents): autoattended-multiagent-pattern + simd-savant 5th-slot#399
Conversation
…c orchestration pattern Captures the transferable patterns from `AdaWorldAPI/WoA` `.claude/v0.1/CLAUDE-CONTEXT.md` into a workspace-agnostic knowledge doc so any project — Rust, Python, TypeScript, Go — can adopt them. Covers the six-step orchestrator loop, the 4-savant meta-reviewer taxonomy (PP-13 brutally-honest-tester / PP-14 convergence-architect / PP-15 baton-handoff-auditor / PP-16 preflight-drift-auditor), the canonical toolchain (Rust tier-1+2+3 plus adapters for Python/TS/Go), six worker-agent iron rules, memory-files pattern, reference indexes, and the adoption checklist for new projects. Triggers (in `READ BY:` header): - ≥4-worker waves - Meta-orchestrator agent spawns - Worker quota-burn retrospectives (§11 scope-tightening lesson) - New repo adopting the pattern (§9 checklist) Includes lance-graph adapter sections (§13-14) that cross-link to existing workspace conventions (cca2a skill, board files, agent ensemble, Model Policy) and identify concrete deltas for adoption here — specifically the `isolation: "worktree"` recommendation surfaced by the Sprint-13 W-I1 retry shared-tree incident. Board hygiene: paired with a one-line entry in CLAUDE.md § Knowledge Base inventory per the Mandatory Board-Hygiene Rule. https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
Adds the simd-savant agent card alongside the project-agnostic 4-savant
taxonomy (PP-13 brutally-honest-tester / PP-14 convergence-architect /
PP-15 baton-handoff-auditor / PP-16 preflight-drift-auditor). Its scope
is the one workspace-specific SIMD invariant codified earlier in this
session:
All SIMD must come from `ndarray::simd` via the polyfill —
`simd.rs` + `simd_ops.rs` > `simd_{type}.rs` per-arch.
Raw intrinsics outside `ndarray/src/simd_*.rs` are a violation.
The savant runs at three checkpoints (PRE-SPAWN / DURING-IMPL /
PRE-MERGE) and owns 8 anti-patterns (AP-SIMD-1..8) covering raw
intrinsics in consumer crates, hand-rolled feature detection,
arch-specific cfg outside the polyfill, unchecked pointer loads,
missing scalar fallback, and duplicated SIMD wrappers.
Hand-offs are explicit per autoattended-pattern §3 discipline:
- SIMD-induced UB / OOB → PP-13 (post-impl gate)
- Missing primitive → file `TD-NDARRAY-SIMD-<NAME>` and route to
ndarray maintainer (do NOT approve inlining the raw intrinsic)
- Spec-vs-code drift → PP-16
- Cross-crate SIMD type aliasing → PP-15
- Compile error → PP-13
Files touched:
- `.claude/agents/simd-savant.md` (new) — the agent card.
- `.claude/agents/BOOT.md` — adds the Quality-lifecycle row for the
simd-savant in the Knowledge Activation table (alongside the four
PP-N rows).
- `.claude/knowledge/autoattended-multiagent-pattern.md` § 14
(lance-graph adapter section) — adds the workspace-specific note
explaining why the 5th savant is an adapter rather than a §3
transferable slot (depends on having a polyfill repo to be the
source-of-truth — not all projects do).
Belegte trigger: Sprint-13 W-I1 PR #398. The salvaged D-CSV-13b
impl inlined raw `_mm512_*` (x86_64) and `vld1q_u64` (aarch64)
intrinsics directly in `crates/lance-graph-contract/src/mul.rs`,
bypassing `ndarray::simd` entirely. Codex P1 (NEON OOB at len==2)
is a direct consequence of AP-SIMD-5 (hand-rolled ptr-load with no
bounds proof). This savant would have caught the violation
PRE-SPAWN (in the worker brief) and PRE-MERGE (in the audit grep).
https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 26cbf84593
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - `ndarray/src/simd.rs` — the public surface; know what's available. | ||
| - `ndarray/src/simd_ops.rs` — high-level vector ops. | ||
| - `ndarray/src/simd_int_ops.rs` — integer batch ops. | ||
| - `ndarray/src/simd_avx512.rs` § the typed-wrapper table at the top | ||
| (lists `F32x16 / I64x8 / U64x8 / I8x32 / U8x32 / ...`). | ||
| - `ndarray/src/simd_neon.rs` — NEON parity with the AVX-512 surface. | ||
| - `ndarray/src/hpc/simd_caps.rs` — the singleton entry point. |
There was a problem hiding this comment.
When this agent is launched from /workspace/lance-graph, these mandatory reference reads resolve under ./ndarray/src/..., but this repo's manifests use ../../../ndarray and the workspace instructions say the ndarray fork is checked out outside the repo. In that context the simd-savant will fail before reading the actual polyfill surface it is supposed to audit; please use the correct sibling/absolute path or document how to locate it from Cargo metadata.
Useful? React with 👍 / 👎.
|
|
||
| ```bash | ||
| # 1. Raw intrinsics in consumer crates — the #1 violation pattern | ||
| grep -rE "\b_mm[0-9]+_[a-z_]+\(" crates/ \ |
There was a problem hiding this comment.
The _mm regex only allows letters and underscores after the vector width, so common intrinsics such as _mm256_set1_epi8 and _mm512_set4_epi32 are missed by the primary raw-intrinsic scan. If a worker uses a fully qualified std::arch::...::_mm*_set1_* call, the import checks below may not catch it either, letting AP-SIMD-1 pass the PRE-MERGE audit despite the stated invariant.
Useful? React with 👍 / 👎.
2 participants
Two related additions to the workspace's meta-infrastructure:
1.
.claude/knowledge/autoattended-multiagent-pattern.mdProject-agnostic distillation of the autoattended multi-agent orchestration pattern from
AdaWorldAPI/WoA.claude/v0.1/CLAUDE-CONTEXT.md. Covers:url_forcross-module-reference trap (with Rust/TS/Python equivalents)isolation: "worktree"recommendation)Also added to CLAUDE.md § Knowledge Base inventory per the Mandatory Board-Hygiene Rule.
2.
.claude/agents/simd-savant.md5th-slot savant card extending the project-agnostic 4-savant taxonomy with a workspace-specific SIMD invariant:
Card includes 8-entry AP-SIMD-N anti-pattern catalogue, owned grep commands for PRE-SPAWN/DURING-IMPL/PRE-MERGE audits, and explicit hand-offs (SIMD-induced UB/OOB → PP-13; missing primitive → file
TD-NDARRAY-SIMD-<NAME>and route to ndarray maintainer; spec-drift → PP-16; cross-crate aliasing → PP-15).Belegte trigger codified in the card: Sprint-13 W-I1 PR #398 inlined raw
_mm512_*andvld1q_u64directly inlance-graph-contract/src/mul.rs, bypassingndarray::simd. The savant's PRE-SPAWN check would have caught the violation in the worker brief..claude/agents/BOOT.mdextended with a 5th Quality-lifecycle row in the Knowledge Activation table (CROSS-CUTTING scope, alongside the four PP-N rows).Files
.claude/knowledge/autoattended-multiagent-pattern.md(NEW, 339 LOC).claude/agents/simd-savant.md(NEW, 218 LOC).claude/agents/BOOT.md(+1 row)CLAUDE.md§ Knowledge Base (+1 row)No code changes; pure meta-infrastructure. Companion follow-up PR fixes PR #398's three SIMD findings under the savant's brief.
https://claude.ai/code/session_01UwJuKqP828qyX1VkLgGJFS
Generated by Claude Code