Skip to content

Handle discrete labels correctly & switch to GridSearchCV for readability#44

Closed
anandawolz wants to merge 1 commit into
mainfrom
ananda-dev
Closed

Handle discrete labels correctly & switch to GridSearchCV for readability#44
anandawolz wants to merge 1 commit into
mainfrom
ananda-dev

Conversation

@anandawolz
Copy link
Copy Markdown

  • Leverage KNNDecoder’s built-in classifier/regressor selection via dtype casting
  • Simplify continuous vs. binary detection and metric computation
  • Replace manual k-loop and 8/9-split with a single GridSearchCV

when plotting the results using built-in functions of CEBRA-lens the axis are not adapted yet, and still show R^2 score, also for classification, but the result is correct now --> will be for a later change

@CeliaBenquet
Copy link
Copy Markdown
Member

This needs to pass the tests first (that's for that PR I wanted to add them :))

@CeliaBenquet
Copy link
Copy Markdown
Member

As discussed with @anandawolz, those changes were transferred and improved in #59. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants