updating from upstream - #5
Merged
Merged
Conversation
…ending the domain from AG listener (#57) * fix(linux_dns_issue): POC * fix(linux_dns_issue): compatible with dotnet 4.7 + summary docs * fix(linux_dns_issue): whitespace * fix(linux_dns_issue): more whitespace * feat(linux_dns_issue): Handling ports and named instances * refactor(linux_dns_issue): some renames + removed the check to see if 'agReplicaInstanceName' is already FQDN * fix(linux_dns_issue): moved named instance handling to 'SplitDomainPort()' + PR suggestions * refactor(linux_dns_issue): PR suggestions + comments + renames * test(Listener): New tests for 'SplitDomainAndPort()' * refactor(Listener): Moving using statements back inside namespace * fix(linux_dns_issue): prefer adding back ports over named instances * refactor(linux_dns_issue): renames * refactor(port preference): simplified if conditions * refactor(Listener.cs): PR suggestions for renames and test data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(linux_dns_issue): Re-trying DNS lookup of instance name after appending the domain from AG listener (factset#57)
fix(linux_dns_issue): POC
fix(linux_dns_issue): compatible with dotnet 4.7 + summary docs
fix(linux_dns_issue): whitespace
fix(linux_dns_issue): more whitespace
feat(linux_dns_issue): Handling ports and named instances
refactor(linux_dns_issue): some renames + removed the check to see if 'agReplicaInstanceName' is already FQDN
fix(linux_dns_issue): moved named instance handling to 'SplitDomainPort()' + PR suggestions
refactor(linux_dns_issue): PR suggestions + comments + renames
test(Listener): New tests for 'SplitDomainAndPort()'
refactor(Listener): Moving using statements back inside namespace
fix(linux_dns_issue): prefer adding back ports over named instances
refactor(linux_dns_issue): renames
refactor(port preference): simplified if conditions
refactor(Listener.cs): PR suggestions for renames and test data